-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the explicit dependency on non-alpaka main library #46829
Remove the explicit dependency on non-alpaka main library #46829
Conversation
cms-bot internal usage |
b02ce8a
to
7827307
Compare
enable gpu |
please test |
+heterogeneous |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46829/42844 |
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
@slava77 is there some specific test we should run for the LST part, or is it enough that is builds correctly ? |
I think it's enough that it builds correctly. |
+1 |
Remove the explicit dependency of alpaka libraries on the non-alpaka main library, since this is now enabled by default.
7827307
to
6bac180
Compare
please test |
+heterogeneous |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46829/42894 |
Pull request #46829 was updated. @jfernan2, @mandrenguyen can you please check and sign again. |
+1 Size: This PR adds an extra 16KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
GPU Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Remove the explicit dependency of alpaka libraries on the non-alpaka main library, since this is now enabled by default in the 15.0.x branch.
PR validation:
Unit tests pass.