Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the explicit dependency on non-alpaka main library #46829

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 29, 2024

PR description:

Remove the explicit dependency of alpaka libraries on the non-alpaka main library, since this is now enabled by default in the 15.0.x branch.

PR validation:

Unit tests pass.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 29, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 29, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 29, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaTest (heterogeneous)
  • RecoTracker/LSTCore (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @makortel, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caa741/43154/summary.html
COMMIT: 7827307
CMSSW: CMSSW_15_0_X_2024-11-29-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46829/43154/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3597272
  • DQMHistoTests: Total failures: 418
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3596834
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 206 log files, 177 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53058
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 53025
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 29, 2024

@slava77 is there some specific test we should run for the LST part, or is it enough that is builds correctly ?

@ariostas
Copy link
Contributor

ariostas commented Dec 3, 2024

is there some specific test we should run for the LST part, or is it enough that is builds correctly ?

I think it's enough that it builds correctly.

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 4, 2024

+1

Remove the explicit dependency of alpaka libraries on the non-alpaka
main library, since this is now enabled by default.
@fwyzard fwyzard force-pushed the remove_explicit_alpaka_library_dependencies branch from 7827307 to 6bac180 Compare December 4, 2024 15:49
@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 4, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 4, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

Pull request #46829 was updated. @jfernan2, @mandrenguyen can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caa741/43243/summary.html
COMMIT: 6bac180
CMSSW: CMSSW_15_0_X_2024-12-04-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46829/43243/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caa741/43243/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caa741/43243/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
2024.202001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 283 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3505629
  • DQMHistoTests: Total failures: 2396
  • DQMHistoTests: Total nulls: 32
  • DQMHistoTests: Total successes: 3503181
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 42582.282 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 24834.911,... ): 7097.047 KiB HLT/Tracking
  • Checked 202 log files, 173 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b5adaf9 into cms-sw:master Dec 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants