-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce session setup #422
Conversation
Agree with you on this one - it's DB specific so can/should just go in the DB's config directory. However, there are a few places where we do have non-DB specific files in that data directory (e.g., templated example config). Could just duplicate them or find another place to put them. |
@ranaalotaibiMS , #416 and other recent PRs introduced a lot of changes, especially around standardizing code formatting, so you'll have to rebase your changes on an updated main branch first. |
34c1bcb
to
ed730c6
Compare
@bpkroth : Rebased |
@ranaalotaibiMS, seems like there are some missing formatting changes. Can you please address those along with the requested example config for testing changes? Thanks! |
Tackled this and added a few more small checks. Will merge after the CI passes and add documentation for the config option during #599 |
This PR introduces functionality for configuring a session by executing predefined statements before the benchmark execution begins. Users should specify the file containing these statements within the tag
<sessionsetupfile> </sessionsetupfile>
in the benchmarks' config files. CC: @bpkrothFor example,
See Also: #192