Add bootstrap installer and a Docker controller Makefile #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you rebase commits from another branch? I merged #752 earlier this week |
* combine with Katie and Xavier's work in epidata-refresh.sh * simplify directory structure using .dockerignore * add in missing dependencies to install.sh * add in changes reviews from Xavier's review
|
I rebased to |
xavier-xia-99
previously approved these changes
Jun 23, 2022
krivard
suggested changes
Jun 24, 2022
There was a problem hiding this comment.
Great work! Changes:
- Be consistent about whether CWD is specified or not (& decide if it's even needed)
- Double-check uses of @ to hide output
- Beware creating a neverending output file
- Probably don't put a random Makefile on someone's filesystem
- Verify if all prepandemic delphi packages are really needed
Co-authored-by: Katie Mazaitis <[email protected]>
* bring driver back * remove docker-logs dir * remove unneeded $(CWD) usage * don't infinitely append to a test log file
|
Going to leave the refactor discussions unresolved so they're easier to find later. |
krivard
reviewed
Jun 27, 2022
Oh sorry, I resolved them. They're listed in issues and each one links back to this PR in the relevant thread for future discussion purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites:
devbranchdevSummary
I had some local devtools laying around and figured I would try merging them with #752. The differences are
--pdbflag option to the testing command.dockerignorefile to control the container contextinstall.shto reintroduce deprecated, though not yet removed, dependenciesJust figured I would see if I could help push this work along. Though I didn't add much, maybe consider it a thorough review, so we can get closer to merging? After this, we can really simplify our dev docs and speed up engineer onboarding time.