Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that endpoint ... are empty #216

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Check that endpoint ... are empty #216

merged 2 commits into from
Nov 15, 2023

Conversation

nmdefries
Copy link
Contributor

Closes #201. Closes #187.

dsweber2
dsweber2 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

covers all the ones I could find, thanks!

@nmdefries nmdefries merged commit b4b709e into dev Nov 15, 2023
10 checks passed
@nmdefries nmdefries deleted the ndefries/check-dots-empty branch November 15, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsweber2 dsweber2 dsweber2 approved these changes

@dshemetov dshemetov Awaiting requested review from dshemetov dshemetov is a code owner

@brookslogan brookslogan Awaiting requested review from brookslogan brookslogan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoints need to check ... is empty issue as an input should throw an error, rather than silently failing
2 participants
@nmdefries @dsweber2