lastest_issue is an epiweek, not a date #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
requested review from
dshemetov,
brookslogan and
dsweber2
as code owners
dshemetov
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the switch in #223 to using
as.Date(tryFormats = ...)instead ofas.Date(format = ...), failed parsing behavior has changed. Now if a value doesn't match any of the provided formats,as.Dateerrors.This has caused
pub_fluview_metato start failing. One of the fields is in YYYYWW (epiweek) format, but was being parsed as a date. Presumably with the old code, this was always being replaced with NA when the parsing failed. Ask for it to be formatted as an epiweek instead.