Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve strange wording on getting started page #292

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Aug 29, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current epidatr main reviewers:
    brookslogan, dshemetov, nmdefries, dsweber2.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).

Change explanations for reviewer

Found some strange wording in the migration to epidatpy. It helps to read the section in context to see that it gets weird (Ctrl + F "We can also request data for a single location at a time").

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

Found some strange wording in the migration to epidatpy.
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vignettes/epidatr.Rmd Show resolved Hide resolved
vignettes/epidatr.Rmd Show resolved Hide resolved
@dshemetov dshemetov merged commit 2ee8867 into dev Aug 29, 2024
9 checks passed
@dshemetov dshemetov deleted the dshemetov-patch-1 branch August 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants