-
Notifications
You must be signed in to change notification settings - Fork 0
Task/add service defaults #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…i/crucible-common-dotnet into task/add-service-defaults
|
||
if (env.IsDevelopment()) | ||
{ | ||
x.SetSampler<AlwaysOnSampler>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have performance impacts in dev? Should it be optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this, yeah. This is for sure not a thing you want to do in production, according to multiple sources, but most examples have it on in dev. I don't mind parameterizing it like we do the other config. I'll add this.
Adds a new ServiceDefaults library (currently entirely OTel-related).
This is extremely WIPish, it's just easier to get the package into the container if I can publish to nuget as I iterate. I know I need to solve this problem better longterm, it's just easier to get the package source into the container env if it's on NuGet for now.
To address a couple of likely questions:
/metrics
endpoint that scrapers like Prometheus can consume. I thought it might be useful in debugging as we get this up and rolling, to make sure we're writing the metrics we want to. I see this being off most of the time in practice except for specialized cases, or to check stuff out in dev.I expect this will change/grow a lot even over the course of my initial implementation, but wanted to get something in there. Very much welcome your thoughts.