Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Trigger other Benchmark workflows #106

Merged
merged 10 commits into from
Jun 24, 2024

Conversation

dipankardas011
Copy link
Contributor

What type of PR is this?

kind/feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer (optional):

@dipankardas011 dipankardas011 marked this pull request as ready for review June 19, 2024 18:07
@dipankardas011 dipankardas011 requested a review from a team as a code owner June 19, 2024 18:07
@dipankardas011
Copy link
Contributor Author

Only place left for testing this script is workflow_dispatch with 2 types of workflows which can have sub_components or not have it

also need to think of do we send one sub_component at a time or all at once like a json array or a string with each having its individual workflow_call?

Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dipankardas011 Thank you the approach here using bash works a lot better.

Some changes still needed. Especially the output to the console which can be much simpler.

.gitignore Show resolved Hide resolved
scripts/project-trigger.sh Outdated Show resolved Hide resolved
scripts/project-trigger.sh Outdated Show resolved Hide resolved
.github/workflows/project-trigger.yml Outdated Show resolved Hide resolved
scripts/project-trigger.sh Outdated Show resolved Hide resolved
@dipankardas011 dipankardas011 changed the title feat: bash script to trigger other workflow files feat: Trigger other Benchmark workflows Jun 21, 2024
Signed-off-by: Dipankar Das <[email protected]>
@dipankardas011
Copy link
Contributor Author

dipankardas011 commented Jun 23, 2024

@rossf7 Should I add color for error and success logs?

Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossf7 Should I add color for error and success logs?

@dipankardas011 No that isn't necessary and makes the code more complex.

Pls revert the changes in 129d110

Better to focus on making sure the text in the echo statements is clear. I suggested a couple of edits and then this is good to go

scripts/project-trigger.sh Outdated Show resolved Hide resolved
scripts/project-trigger.sh Outdated Show resolved Hide resolved
Signed-off-by: Dipankar Das <[email protected]>
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💚

@rossf7 rossf7 merged commit 6be6e66 into cncf-tags:main Jun 24, 2024
1 of 2 checks passed
@dipankardas011
Copy link
Contributor Author

LGTM 💚

But the env var for the gh_pat token?

@rossf7
Copy link
Contributor

rossf7 commented Jun 25, 2024

But the env var for the gh_pat token?

@dipankardas011 We need to open a service desk ticket to request a new token. I'll take care but will need some help from the other leads.

@rossf7
Copy link
Contributor

rossf7 commented Jun 26, 2024

@dipankardas011 Token is added as a secret and working well here.
#7 (comment)

Nice job! 🚀

There is an issue with the deploy step itself. Will debug that later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACTION] Add release trigger
2 participants