-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Trigger other Benchmark workflows #106
feat: Trigger other Benchmark workflows #106
Conversation
Only place left for testing this script is workflow_dispatch with 2 types of workflows which can have sub_components or not have it also need to think of do we send one sub_component at a time or all at once like a json array or a string with each having its individual workflow_call? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipankardas011 Thank you the approach here using bash works a lot better.
Some changes still needed. Especially the output to the console which can be much simpler.
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
9117386
to
0eb55bc
Compare
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
@rossf7 Should I add color for error and success logs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossf7 Should I add color for error and success logs?
@dipankardas011 No that isn't necessary and makes the code more complex.
Pls revert the changes in 129d110
Better to focus on making sure the text in the echo statements is clear. I suggested a couple of edits and then this is good to go
Signed-off-by: Dipankar Das <[email protected]>
129d110
to
5ec943c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💚
But the env var for the gh_pat token? |
@dipankardas011 We need to open a service desk ticket to request a new token. I'll take care but will need some help from the other leads. |
@dipankardas011 Token is added as a secret and working well here. Nice job! 🚀 There is an issue with the deploy step itself. Will debug that later |
What type of PR is this?
kind/feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer (optional):