Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Quote kubeconfig and add sleep to deploy step #108

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: Quote kubeconfig and add sleep to deploy step #108

merged 1 commit into from
Jun 27, 2024

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Jun 26, 2024 •
edited
Loading

What type of PR is this?

kind/bug

What this PR does / why we need it:

  • Adds quoting to echo statement when creating kubeconfig from secret
  • Adds a sleep for 10 seconds before kubectl wait command to allow flux resources to be created.

Which issue(s) this PR fixes:

Follow up to #99

Special notes for your reviewer (optional):

cc @dipankardas011

@rossf7 rossf7 requested a review from a team as a code owner June 26, 2024 17:43
nikimanoledaki
nikimanoledaki approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @rossf7! :shipit:

@rossf7 rossf7 merged commit 6042e63 into cncf-tags:main Jun 27, 2024
1 of 2 checks passed
@rossf7 rossf7 deleted the fix/kubeconfig branch June 27, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikimanoledaki nikimanoledaki nikimanoledaki approved these changes

@leonardpahlke leonardpahlke Awaiting requested review from leonardpahlke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rossf7 @nikimanoledaki