Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal 2: Run] Call and define benchmark tests as GitHub Action jobs & workflows #93

Merged
merged 16 commits into from
Aug 7, 2024

Conversation

nikimanoledaki
Copy link
Contributor

@nikimanoledaki nikimanoledaki commented May 14, 2024

What type of PR is this?

kind/enhancement

What this PR does / why we need it:

This proposal provides an automated way to fetch and run the benchmark tests in a modular way.

For context, please read Proposal 1 here first :)

Which issue(s) this PR fixes:

Fixes #86

Special notes for your reviewer (optional):

Copy link
Contributor

@locomundo locomundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added/proposed a few little things

website/content/docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
website/content/docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
website/content/docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
website/content/docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
@nikimanoledaki nikimanoledaki force-pushed the proposal-002-run branch 2 times, most recently from 4377aa0 to 7c6970c Compare May 31, 2024 10:10
locomundo pushed a commit to nikimanoledaki/green-reviews-tooling that referenced this pull request Jun 26, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far.
locomundo pushed a commit to nikimanoledaki/green-reviews-tooling that referenced this pull request Jun 26, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far.

Co-authored-by: nikimanoledaki <[email protected]>
Signed-off-by: locomundo <[email protected]>
locomundo pushed a commit to nikimanoledaki/green-reviews-tooling that referenced this pull request Jun 26, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far.

Signed-off-by: Flavia Paganelli <[email protected]>
Co-Authored-By: nikimanoledaki <[email protected]>
locomundo pushed a commit to nikimanoledaki/green-reviews-tooling that referenced this pull request Jun 26, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far.

Co-authored-by: nikimanoledaki <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
@nikimanoledaki nikimanoledaki changed the title Add Proposal 2: Run [Proposal 2: Run] Call and define benchmark tests as GitHub Action jobs & workflows Jun 28, 2024
nikimanoledaki added a commit to nikimanoledaki/green-reviews-tooling that referenced this pull request Jun 28, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far.

Co-authored-by: nikimanoledaki <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
@nikimanoledaki nikimanoledaki force-pushed the proposal-002-run branch 3 times, most recently from e783d3b to 4b0af07 Compare June 28, 2024 12:30
@nikimanoledaki nikimanoledaki marked this pull request as ready for review June 28, 2024 12:35
@nikimanoledaki nikimanoledaki requested a review from a team as a code owner June 28, 2024 12:35
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikimanoledaki @locomundo Great job this is looking good! 🚀

A few thoughts from me. Mainly on my favourite topic. Deleting stuff! 🧹😄

docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AntonioDiTuri AntonioDiTuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job so far! I have only pointed out minor rephrasing and some questions I have

docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Show resolved Hide resolved
nikimanoledaki and others added 12 commits July 22, 2024 13:19
Co-authored-by: locomundo <[email protected]>
Signed-off-by: nikimanoledaki <[email protected]>

* Remove option 1 of defining job in-line
* Move proposal 2 to docs/proposals
* Defining test jobs for proposal 2
* Split use cases and add sections for auth, versioning

Signed-off-by: Flavia Paganelli <[email protected]>
Co-authored-by: Niki Manoledaki <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Co-authored-by: locomundo <[email protected]>
Signed-off-by: nikimanoledaki <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Signed-off-by: locomundo <[email protected]>
Signed-off-by: Flavia Paganelli <[email protected]>
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @locomundo and @nikimanoledaki for your great work on this

* Clean up empty sections to be ready to merge

Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: nikimanoledaki <[email protected]>
Copy link
Contributor

@AntonioDiTuri AntonioDiTuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor fixing here and there: I personally would get rid of the terms "benchmarking-tests" to avoid additional confusion. Let me know what you think, we are very close :)

docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Outdated Show resolved Hide resolved
docs/proposals/proposal-002-run.md Show resolved Hide resolved
nikimanoledaki and others added 3 commits August 7, 2024 14:22
Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: nikimanoledaki <[email protected]>
Co-authored-by: AntonioDiTuri <[email protected]>
Signed-off-by: nikimanoledaki <[email protected]>
@AntonioDiTuri AntonioDiTuri merged commit 75c0857 into cncf-tags:main Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACTION] Write a Proposal for Run: Call and define benchmark tests as GitHub Action jobs & workflows
6 participants