Make clippy pedantic happy (#499)

Signed-off-by: Sergio Castaño Arteaga <[email protected]>

clotributor-apiserver/src/handlers.rs

@@ -38,7 +38,7 @@ struct RouterState {
 }
 
 /// Setup HTTP server router.
-pub(crate) fn setup_router(cfg: Arc<Config>, db: DynDB) -> Result<Router> {
+pub(crate) fn setup_router(cfg: &Arc<Config>, db: DynDB) -> Result<Router> {
     // Setup some paths
     let static_path = cfg.get_string("apiserver.staticPath")?;
     let index_path = Path::new(&static_path).join("index.html");
@@ -94,6 +94,7 @@ async fn search_issues(State(db): State<DynDB>, RawQuery(query): RawQuery) -> im
 }
 
 /// Helper for mapping any error into a `500 Internal Server Error` response.
+#[allow(clippy::needless_pass_by_value)]
 fn internal_error<E>(err: E) -> StatusCode
 where
     E: Into<Error> + Display,
@@ -211,6 +212,6 @@ mod tests {
             .unwrap()
             .build()
             .unwrap();
-        setup_router(Arc::new(cfg), Arc::new(db)).unwrap()
+        setup_router(&Arc::new(cfg), Arc::new(db)).unwrap()
     }
 }

clotributor-apiserver/src/main.rs

@@ -1,3 +1,6 @@
+#![warn(clippy::all, clippy::pedantic)]
+#![allow(clippy::doc_markdown)]
+
 use crate::db::PgDB;
 use anyhow::{Context, Result};
 use clap::Parser;
@@ -37,7 +40,7 @@ async fn main() -> Result<()> {
 
     // Setup logging
     if std::env::var_os("RUST_LOG").is_none() {
-        std::env::set_var("RUST_LOG", "clotributor_apiserver=debug,tower_http=debug")
+        std::env::set_var("RUST_LOG", "clotributor_apiserver=debug,tower_http=debug");
     }
     let s = tracing_subscriber::fmt().with_env_filter(EnvFilter::from_default_env());
     match cfg.get_string("log.format").as_deref() {
@@ -56,7 +59,7 @@ async fn main() -> Result<()> {
 
     // Setup and launch API HTTP server
     debug!("setting up apiserver");
-    let router = handlers::setup_router(cfg.clone(), db)?;
+    let router = handlers::setup_router(&cfg.clone(), db)?;
     let addr: SocketAddr = cfg.get_string("apiserver.addr")?.parse()?;
     info!("apiserver started");
     info!(%addr, "listening");

clotributor-registrar/src/main.rs

@@ -1,3 +1,6 @@
+#![warn(clippy::all, clippy::pedantic)]
+#![allow(clippy::doc_markdown)]
+
 use crate::db::PgDB;
 use anyhow::{Context, Result};
 use clap::Parser;
@@ -32,7 +35,7 @@ async fn main() -> Result<()> {
 
     // Setup logging
     if std::env::var_os("RUST_LOG").is_none() {
-        std::env::set_var("RUST_LOG", "clotributor_registrar=debug")
+        std::env::set_var("RUST_LOG", "clotributor_registrar=debug");
     }
     let s = tracing_subscriber::fmt().with_env_filter(EnvFilter::from_default_env());
     match cfg.get_string("log.format").as_deref() {

clotributor-tracker/src/github.rs

@@ -80,6 +80,7 @@ impl repo_view::RepoViewRepository {
                                 .expect("date to be valid");
 
                         // Prepare issue
+                        #[allow(clippy::cast_possible_truncation)]
                         let mut issue = Issue {
                             issue_id: node.database_id.unwrap(),
                             title: node.title.clone(),
@@ -134,8 +135,8 @@ impl GH for GHGraphQL {
             .saturating_sub(365.days())
             .format(&Iso8601::DEFAULT)?;
         let vars = repo_view::Variables {
-            owner,
             repo,
+            owner,
             issues_since,
         };
         let req_body = &RepoView::build_query(vars);

clotributor-tracker/src/main.rs

@@ -1,3 +1,6 @@
+#![warn(clippy::all, clippy::pedantic)]
+#![allow(clippy::doc_markdown)]
+
 use crate::{db::PgDB, github::GHGraphQL};
 use anyhow::{Context, Result};
 use clap::Parser;
@@ -34,7 +37,7 @@ async fn main() -> Result<()> {
 
     // Setup logging
     if std::env::var_os("RUST_LOG").is_none() {
-        std::env::set_var("RUST_LOG", "clotributor_tracker=debug")
+        std::env::set_var("RUST_LOG", "clotributor_tracker=debug");
     }
     let s = tracing_subscriber::fmt().with_env_filter(EnvFilter::from_default_env());
     match cfg.get_string("log.format").as_deref() {

clotributor-tracker/src/tracker.rs

@@ -39,6 +39,7 @@ pub(crate) struct Repository {
 
 impl Repository {
     /// Update repository's GitHub data.
+    #[allow(clippy::cast_possible_truncation)]
     fn update_gh_data(&mut self, gh_repo: &repo_view::RepoViewRepository) -> Result<bool> {
         // Description
         self.description = gh_repo.description.clone();
@@ -190,7 +191,7 @@ impl Issue {
     /// Populate the issue with information extracted from the labels, like the
     /// issue kind, its difficulty, etc.
     pub(crate) fn populate_from_labels(&mut self) {
-        for label in self.labels.iter() {
+        for label in &self.labels {
             // Area
             if label.contains("docs") || label.contains("documentation") {
                 self.area = Some(IssueArea::Docs);
@@ -359,7 +360,7 @@ async fn track_repository(
     let issues_in_db = db.get_repository_issues(repo.repository_id).await?;
 
     // Register/update new or outdated issues
-    for issue in issues_in_gh.iter_mut() {
+    for issue in &mut issues_in_gh {
         let digest_in_db = find_issue(issue.issue_id, &issues_in_db);
         if issue.digest != digest_in_db {
             db.register_issue(&repo, issue).await?;
@@ -651,6 +652,7 @@ mod tests {
     }
 
     #[tokio::test]
+    #[allow(clippy::too_many_lines)]
     async fn run_register_one_issue_and_unregister_another_successfully() {
         let cfg = setup_test_config(&[TOKEN1]);
         let mut db = MockDB::new();
@@ -791,7 +793,7 @@ mod tests {
                 "creds.githubTokens",
                 tokens
                     .iter()
-                    .map(|t| t.to_string())
+                    .map(std::string::ToString::to_string)
                     .collect::<Vec<String>>(),
             )
             .unwrap()