Repository navigation
fix: make productLogoUrl optional - #161
Open
yuanchen8911 wants to merge 1 commit into
Open
yuanchen8911 wants to merge 1 commit into
yuanchen8911 wants to merge 1 commit into
Conversation
janetkuo
reviewed
Oct 28, 2026
Member
|
@copilot resolve the merge conflicts in this pull request |
Match validator requiredness to the documented company-logo fallback. Add isolated regression coverage for omitted and supplied logo values. Clarify the optional product logo placeholder in the v1.33-v1.37 templates. Fixes cncf#160. Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
yuanchen8911
force-pushed
the
fix/optional-product-logo
branch
2 times, most recently
from
October 30, 2026 13:35
50c04d2 to
3d7a548
Compare
Contributor
Author
|
resolved the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omitting
metadata.productLogoUrlcurrently fails validation even though the submission instructions document it as optional with a company-logo fallback. Mark the field optional while preserving the existing checks for supplied values.Add nine regression cases through
validateProduct, covering omitted, empty, and null values; reachable and unreachable URLs under both field spellings; non-string values; and placeholders. The tests use local fixtures and stubbed HTTP responses.Correct the
productLogoUrlplaceholder to[Product Logo URL, optional]in all five templates,docs/AIConformance-1.33.yamlthroughdocs/AIConformance-1.37.yaml. This makes the templates match the documented optional field. Existing submissions are unchanged.Closes #160.
Validation
go test -race -v -tags validate ./scripts/...go test -race -v -tags landscape ./scripts/...go vet -tags validate ./scripts/...git diff --checkScope
The landscape generator's missing company-logo fallback is tracked separately: #162. This PR changes validator requiredness and template guidance.
The product-submission checklist is not applicable to this validator and template change.