[WIP] repo: Add buf linting
#47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initially just for unused imports Fix cncf#45 Signed-off-by: Ryan Northey <[email protected]>
phlax
commented
Jun 24, 2022
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| bazel run @com_github_bufbuild_buf//:bin/buf lint -- --path xds | |||
| bazel run @com_github_bufbuild_buf//:bin/buf lint -- --path udpa | |||
There was a problem hiding this comment.
need to figure how/where best to run this
phlax
commented
Jun 24, 2022
| name = "buf", | ||
| srcs = [ | ||
| "@com_github_bufbuild_buf//:bin/buf", | ||
| ], |
There was a problem hiding this comment.
envoy setup is tagged manual - might want to do the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initially just for unused imports
Fix #45
Signed-off-by: Ryan Northey [email protected]