Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerfile: Optimization of image size #26

Merged
merged 1 commit into from
Jun 6, 2024
Merged

dockerfile: Optimization of image size #26

merged 1 commit into from
Jun 6, 2024

Conversation

horecoli
Copy link
Contributor

@horecoli horecoli commented May 3, 2024

This change uses multi-stage build of image
which makes image size much smaller.
It also uses debian slim as base image.

Issues:
Refs: #24

@horecoli
dockerfile: Optimization of image size
e04ceb7 
This change uses multi-stage build of image
which makes image size much smaller.
It also uses debian slim as base image.

Signed-off-by: horecoli <[email protected]>
@horecoli
Copy link
Contributor Author

horecoli commented May 3, 2024 •
edited
Loading

Difference between original image and image with this change:
ubuntu@testsuite:~/cluster_tools_slim_test/cluster_tools$ docker images
REPOSITORY TAG IMAGE ID CREATED SIZE
horecoli/cluster-tools test_slim_image 50f341eca255 9 days ago 1.23GB
cluster-tools original 235feb8f8c4f 13 days ago 5.36GB

Build image with this change in DockerHub:
image

Original image in DockerHub:
image

If someone would like to test this new image it is available in my repository in DockerHub: https://hub.docker.com/layers/horecoli/cluster-tools/test_slim_image/images/sha256-1d0d8837ed57933b96d1d3759d7191c6d7cefacac4c1c49649eab5ea8dce2dbb?context=repo

@taylor taylor requested review from wvwatson and denverwilliams May 7, 2024 15:22
denverwilliams
denverwilliams approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@denverwilliams denverwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-mat
Copy link
Collaborator

Tested by this action in cnf-testsuite
https://github.com/cnti-testcatalog/testsuite/actions/runs/9366756183
all passed.

lgtm and ready for merge from my point of view.

@martin-mat martin-mat merged commit 71f9497 into cnf-testsuite:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denverwilliams denverwilliams denverwilliams approved these changes

@wvwatson wvwatson Awaiting requested review from wvwatson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@horecoli @martin-mat @denverwilliams