[ realignment for new esp82xx to flash firmware/page.mpfs ] #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old esp82xx code uses 0x00000 and 0x40000 locations, this new esp82xx code on this repo was never adjusted to reflect that difference. the page.mpfs mpfs_start_at location changed as well in this esp82xx code but, it was also never adjusted to reflect that difference in menuinterface.js. if you were to flash page.mpfs via webgui(then refresh), you'd get file not found because it points to location 65536. this isn't possible with 0x00000 and 0x10000 locations being firmware bins. the MFS_PAGE_OFFSET location defined in user.cfg which is really outlined from esp82xx/include/spi_memory_addrs(0x7c000 + 0x3000 + 0x3000) is a misaligned starting address, the issue with that doesn't reveal itself until you flash a page.mpfs > 65536 in filesize via the webgui.. that issue is a pattern of missing chunks of 8192 bytes every 65536 increments which you can flash dump and compare to prove :)
i've explained the reason more in depth here.
#93