Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ameba to 1.6.1 #2156

Closed
wants to merge 1 commit into from
Closed

Conversation

collivier
Copy link
Collaborator

The latest crystal versions ask to upgrade ameba
Please see [1] and [2] for more details.

[1] crystal-ameba/ameba#372
[2] crystal-ameba/ameba#373

Description

# crystal --version
Crystal 1.12.2 (2024-05-31)

LLVM: 17.0.6
Default target: x86_64-alpine-linux-musl

Please see [1] and [2]

[1] crystal-ameba/ameba#372
[2] crystal-ameba/ameba#373

Signed-off-by: Cédric Ollivier <[email protected]>
Copy link
Collaborator

@kosstennbl kosstennbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, change is long-needed and awaited, but we need to update crystal on our runners to make it (see GH actions)

And about crystal update - it seems that there's a circular dependency for us:
Crystal update requires ameba update and ameba update requires crystal update.
See: #1814 #1811

@kosstennbl
Copy link
Collaborator

As ameba is removed from dependencies now based on #2157, I think that ticket can be closed.

Further steps for ameba implementation (and also crystal update which is necessary for newer ameba) are #2158 and #2159.

@collivier collivier closed this Dec 9, 2024
@collivier
Copy link
Collaborator Author

agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants