Naming: rename setup and cleanup tasks #2184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosstennbl
requested review from
denverwilliams,
agentpoyo and
HashNuke
as code owners
|
Based on #2182, should be merged only after it or rebased |
kosstennbl
force-pushed
the
#2181-rename-setup-tasks
branch
2 times, most recently
from
9739fb9 to
a41b684
Compare
added 2 commits
December 18, 2024 15:26
Refs: #2176 Add installation_priority parameter for specification of order for installation of deployments. Signed-off-by: Konstantin Yarovoy <[email protected]>
Refs: #2181 Rename cnf_setup, cnf_cleanup and cluster_api_setup, cluster_api_cleanup tasks to cnf_install, cnf_uninstall and cluster_api_install, cluster_api_uninstall. Change documentation, specs and code accordingly. Signed-off-by: Konstantin Yarovoy <[email protected]>
svteb
force-pushed
the
#2181-rename-setup-tasks
branch
from
a41b684 to
ace6b29
Compare
collivier
reviewed
Dec 19, 2024
| @@ -134,6 +134,21 @@ deployments: | |||
| ... | |||
| ``` | |||
|
|
|||
| ##### Deployment priority | |||
|
|
|||
| To ensure deployments are executed in a specific order, you can use the `priority` parameter. Deployments are processed in ascending order of their `priority` values, starting with the lowest. During uninstallation, the order is reversed, processing from the highest `priority` value to the lowest. If the `priority` parameter is not specified, it defaults to 0. | |||
There was a problem hiding this comment.
uninstallation looks a bit weird ? removal ?
There was a problem hiding this comment.
To be honest I feel like the opposite of removal would be addition. I dont see the need to not use the word "uninstallation", it feels like it reads well as is + it actually conforms with the command name that is used. Additionally in helm documentation they also use the words install/uninstall. This applies to all other comments you left.
collivier
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename cnf_setup, cnf_cleanup and
setuptasks to cnf_install, cnf_uninstall,install_dependenciesChange documentation, specs and code accordingly
Issues:
Refs: #2181