Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sassc sprockets #1

Closed
wants to merge 19 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
app/assets/javascripts/comfy/vendor/* linguist-vendored
app/assets/stylesheets/comfy/vendor/* linguist-vendored
app/assets/builds/* linguist-generated
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,5 @@ coverage/
/storage
db/cms_fixtures/test-site/
.idea

/node_modules
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Fork the project. Optionally, create a branch you want to work on.

### 2. Get it running locally

- Install NodeJS and yarn
- Install JS dependencies with `yarn`
- Install gem dependencies with `bundle install`
- There's nothing to configure, by default database is SQLite so it will be
created for you. Just run `bundle exec rake db:migrate`
Expand All @@ -21,6 +23,7 @@ Fork the project. Optionally, create a branch you want to work on.
- Create a few small pull requests instead of a humoungous one. I can merge small stuff faster.
- When adding new code just make sure it follows the same slyle as the existing code.
- Avoid adding 3rd party dependencies if you can.
- If you make any changes to JS/CSS files, don't forget to build them (yarn build && yarn build:css) before committing.
- Tests please, but nothing complicated. UnitTest / Fixtures all the way. Make sure all tests pass.
- Run `bundle exec rubocop` and fix any issues raised.

Expand Down
2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ group :development, :test do
gem 'byebug', '~> 11.1.0', platforms: %i[mri mingw x64_mingw]
gem 'gem-release'
gem 'image_processing', '>= 1.12.0'
gem 'propshaft', '~> 1.1.0'
gem 'sqlite3', '~> 1.6.7'
# gem 'mysql2', '~> 0.5'
# gem 'pg', '~> 1.5.4'
Expand All @@ -31,6 +32,7 @@ group :test do
gem 'minitest', '>= 5.23.0'
gem 'minitest-reporters', '>= 1.6.1'
gem 'mocha', '>= 2.3.0', require: false
gem 'puma'
gem 'rails-controller-testing', '~> 1.0.5'
gem 'rubocop', '~> 1.63.0', require: false
gem 'rubocop-minitest'
Expand Down
Loading
Loading