Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC-75] Document guidance for hybrid and multi-cloud #19123

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[DOC-75] Document guidance for hybrid and multi-cloud #19123

wants to merge 8 commits into from

Conversation

mdlinville
Copy link
Contributor

@mdlinville mdlinville commented Nov 12, 2024 •
edited
Loading

[DOC-75] Document guidance for hybrid and multi-cloud

  • Added for v24.3, v24.2, v24.1, v24.2
  • Driven by a common include

Preview

src/current/v23.2/hybrid-and-multi-cloud.md
src/current/v24.1/hybrid-and-multi-cloud.md
src/current/v24.2/hybrid-and-multi-cloud.md
src/current/v24.3/hybrid-and-multi-cloud.md

Tests

  • Local build
  • Linkcheck

@github-actions GitHub Actions
Copy link

Files changed:

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit e8b4099
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67354099fa2b57000865674c

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit e8b4099
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/673540997f29d6000828fe94

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit e8b4099
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67354099ad23f20008f013fc
😎 Deploy Preview https://deploy-preview-19123--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbookham7
Copy link
Contributor

Small typo on the following line.

**In a multi-region deployment, we recommend that you use manifests. Refer to Deploy CockroachDB on GKE for details.

@mdlinville
Copy link
Contributor Author

Small typo on the following line.

**In a multi-region deployment, we recommend that you use manifests. Refer to Deploy CockroachDB on GKE for details.

In case you are referring to the unbalanced bold, that's fixed. I also adjusted the link title to hopefully be more accurate.

mdlinville
mdlinville commented Nov 12, 2024
View reviewed changes
Copy link
Contributor Author

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording tweaks while re-reading

src/current/_includes/common/hybrid-multi-cloud.md Outdated Show resolved Hide resolved
src/current/_includes/common/hybrid-multi-cloud.md Outdated Show resolved Hide resolved
src/current/_includes/common/hybrid-multi-cloud.md Outdated Show resolved Hide resolved
src/current/_includes/common/hybrid-multi-cloud.md Outdated Show resolved Hide resolved
src/current/_includes/common/hybrid-multi-cloud.md Outdated Show resolved Hide resolved
src/current/_includes/common/hybrid-multi-cloud.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscasano chriscasano Awaiting requested review from chriscasano

@jphaugla jphaugla Awaiting requested review from jphaugla

@mbookham7 mbookham7 Awaiting requested review from mbookham7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdlinville @mbookham7