Preliminary macOS support for nocc mode#1101
Merged
Merged
Conversation
luigix25
requested review from
joergroedel,
msft-jlange,
peterfang and
stefano-garzarella
as code owners
Collaborator
Author
|
Addressed review comments:
|
stefano-garzarella
added
the
in-review
`memory-backend-memfd` is required for `guest_memfd`. Since `nocc` mode does not boot a confidential guest, `guest_memfd` is not needed, and a portable memory backend can be used instead. Being a linux-specific backend, this prevents booting SVSM on a different operating system. Also, remove `reserve` from the backend parameters, that is linux-specific and not needed in nocc mode. This is preliminary work to allow SVSM to boot on macOS using tcg. Suggested-by: Stefano Garzarella <sgarzare@redhat.com> Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
`grep -P` is a GNU grep extension not available on macOS and *BSD, where the system grep is BSD grep. Replace it with an equivalent `sed` expression to extract the QEMU version string. Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
Collaborator
Author
|
improved commit message @stefano-garzarella |
stefano-garzarella
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to boot SVSM on macOS (and probably *BSD)
The changes are minimal:
grep -Pis GNU-only)Note:
virtio-vsockandvirtio-blkwill NOT work as is, as they require vhost-device, that is linux-specific. We could fall back to vhost-user, but is not really needed for now.Note 2: cross compiling on ARM is still not possible yet. There is some ongoing work but is not ready yet (#971 #981)
Note 3: IGVM also relies on some GNU-only commands, I opened a PR to fix it (microsoft/igvm#123)