Skip to content

test(utils): fix flaky SIGTERM-ignored terminate test (bash tail-exec) #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CMGS merged 1 commit into from
Jul 4, 2026
+3 −2
Merged

test(utils): fix flaky SIGTERM-ignored terminate test (bash tail-exec) #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions utils/process_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,9 @@ func TestTerminateProcess_InvalidPID(t *testing.T) {
}

func TestTerminateProcess_SIGTERMIgnored_FallsBackToKill(t *testing.T) {
// Process that traps SIGTERM: won't die from SIGTERM alone.
cmd := exec.Command("bash", "-c", `trap "" TERM; sleep 60`)
// Traps SIGTERM so only SIGKILL can end it. The trailing "; :" stops bash from
// tail-exec'ing into sleep, which would rename argv0 and fail the "bash" cmdline check.
cmd := exec.Command("bash", "-c", `trap "" TERM; sleep 60; :`)
if err := cmd.Start(); err != nil {
t.Fatalf("start: %v", err)
}
Expand Down
Loading