385 adapter the taobaominigame ClearLRU procedure #17230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.taobao platform will clear tmp folder automatically. 2.when cachecount below 3, it will trigger LRU. 3.zip file, the path maybe is a zipfile.
Interface Check ReportThis pull request does not change any public interfaces ! |
| return; | ||
| let clearCachCount = Math.floor(caches.length / 3); | ||
| // 大于3则清理1/3， 小于等于3则全部清理 | ||
| if(clearCachCount > 3){ |
There was a problem hiding this comment.
You can use caches.length >= 12 instead of clearCacheCount > 3.
And below, you can use caches.length < 3 instead of clearCacheCount === 0.
This way, when caches.length < 3, you won't need to execute Math.floor(caches.length / 3).
可以使用 caches.length >= 12 代替 clearCacheCount > 3
下面可以使用 caches.length < 3 代替 clearCachCount === 0
这样可以使得当 caches.length < 3 时不用执行 Math.floor(caches.length / 3)
There was a problem hiding this comment.
change to :
if(caches.length < 3){
console.warn("Due to caching large files in the game, there is insufficient storage space. Now starting forced cleaning.");
}
else{
caches.length = Math.floor(caches.length / 3);
}
…w 3 without div 3
bofeng-song
reviewed
Jun 27, 2024
| if (caches.length === 0) { | ||
| cleaning = false; | ||
| return; | ||
| // 大于3则清理1/3， 小于等于3则全部清理 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Fixes #17040 : taobao Platform can not trigger clearLRU
Continuous Integration
This pull request:
Compatibility Check
This pull request: