Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 19659 fix 3b #20650

Open
wants to merge 4 commits into
base: v4
Choose a base branch
from
Open

Issue 19659 fix 3b #20650

wants to merge 4 commits into from

Commits on Feb 2, 2021

  1. small fix with CCLOGs

    First approach to see the problem of wrapping words in different languages
    mnievas committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    b5151f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Proposal 1 Korean failing

    Solution 1 with wrapping failing on Korean languages
    mnievas committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    5568ae2 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2021

  1. wordSeparatorMode

    Same languages like Spanish has space (32) as word separator.  Other like Chinese has no separator.
    
    The current implementation based the decision of which char is a word separator on the location of the device. Some games let the user decide the language from a settings, so it is good to let them th choice.
    
    CJK unicodes has a len of 3 or more.
    
    I added these option for the developer to choose from:
    
    WordSeparatorBasedOnDevice:   current implementation
    
    WordSeparatorSpaceSlashNotHighUnicode:  Spaces and '-' will be consider words separators.  Recommended for Korean
    
    WordSeparatorSpaceSlashAndKCJ: Spaces, '-' and KCJ unicodes will be consider words separators.  Recommended for Spanish
    
    You can see the test on:
    Node:UI > GUI Dynamic Create Test > RichTest Test > language
    
    The fnction findSplitPositionForWord receives the parameter wordSeparatorMode and chooses the inlinen function (charWrappableFunctionPointer) to be use in getNextWordPos and then in std::find_if to look for a good spot to but the sentence.
    mnievas committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    73472c1 View commit details
    Browse the repository at this point in the history
  2. Rolling back guild.grandle

    mnievas committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    6384604 View commit details
    Browse the repository at this point in the history