[1.9] Backports and Documentation Fixes #4098
Conversation
Also, adds --trace to SIM_ARGS if VERILATOR_TRACE is set.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable/1.9 #4098 +/- ##
==============================================
- Coverage 64.50% 63.71% -0.79%
==============================================
Files 49 49
Lines 9491 9516 +25
Branches 2546 2732 +186
==============================================
- Hits 6122 6063 -59
- Misses 2812 2878 +66
- Partials 557 575 +18 ☔ View full report in Codecov by Sentry. |
* Set CXXFLAGS appropriately now that they are being used * Update LDCXXSHARED variable now that it is being used * Add verbose switch when compiling cocotb for testing purposes
|
Thanks for those backports. Please don't merge them yet, I'm working on some automation that I'd like to test out first. |
|
Looks like our new backports GH action is intelligent enough to find the backports for #4089 in here (https://github.com/cocotb/cocotb/actions/runs/10457942861/job/28958681130?pr=4089). Cool, but that means we'll just do the manual backports here. |
There was a problem hiding this comment.
The documentation changes need to go into master first and then into the stable branch. Can you remove them from this PR, @ktbarrett, or should I do that?
|
I split it out. I guess this PR should close and just use the new labels? |
|
I opened #4111 with pretty much the same content as this one here. (Officially) Not to get my PR count up, but to test out some of the backport automation and tooling. Turns out, we're not fully there yet where everything is automated: partially due to us changing the directory layout and associated merge conflicts, partially due to bugs in the backport tool (sorenlouv/backport#505, sorenlouv/backport#506) that got me into writing some TypeScript this evening. |
Backports #4089 and #4095 and fixes some issues with the documentation notice by @jonpovey.