celeryconfig.py: parse a bool from BROKER_USE_SSL environment variable. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BROKER_USE_SSL is read from the environ and if it exists it will be a string and unless it is an empty string it will always eval true. So parse it properly.
|
Interesting, indeed the way it is parsed currently is a source of confusion. Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BROKER_USE_SSL is read from the environ and if it exists it will be a
string and unless it is an empty string it will always eval true. So
parse it properly.
To replicate the issue just try to set it to "False" in the env and see that it always to fail to connect, because the string "False" always evals true. The only way to use the
BROKER_USE_SSLenvironment variable to disable ssl, is to set it to the empty string which I don't think was the intension (and so this patch does not support).