Skip to content

fix: update Join button CSS selectors for YouTube's new DOM #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImprovedTube merged 1 commit into from
Mar 7, 2026
Merged

fix: update Join button CSS selectors for YouTube's new DOM #3673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions js&css/extension/www.youtube.com/appearance/details/details.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ html[it-subscribe='transparent'] #subscribe-button button {background-color:rgba
html[it-subscribe='remove_label'] #subscribe-button button .yt-spec-button-shape-next__button-text-content,
html[it-subscribe='hidden'] #subscribe-button,
html[it-join='remove_label'] #sponsor-button button .yt-spec-button-shape-next__button-text-content,
html[it-join='remove_label'] ytd-sponsorships-offer-module-renderer button .yt-spec-button-shape-next__button-text-content,
html[it-join='hidden'] #sponsor-button,
html[it-join='hidden'] ytd-sponsorships-offer-module-renderer,
html[it-purchase='remove_label'] #purchase-button button .yt-spec-button-shape-next__button-text-content,
html[it-purchase='hidden'] #purchase-button,
html[it-youtubeDetailButtons='remove_labels'] #menu button div:nth-child(2),
Expand Down
29 changes: 29 additions & 0 deletions tests/unit/join-button-hiding.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Test for Issue #3669: Join button not hiding when set to Hidden

const fs = require('fs');
const path = require('path');

describe('Join Button Hiding (#3669)', () => {
let detailsCssContent;

beforeAll(() => {
const filePath = path.join(__dirname, '../../js&css/extension/www.youtube.com/appearance/details/details.css');
detailsCssContent = fs.readFileSync(filePath, 'utf8');
});

test('should hide legacy #sponsor-button', () => {
expect(detailsCssContent).toContain("html[it-join='hidden'] #sponsor-button");
});

test('should hide new ytd-sponsorships-offer-module-renderer', () => {
expect(detailsCssContent).toContain("html[it-join='hidden'] ytd-sponsorships-offer-module-renderer");
});

test('should remove label from legacy #sponsor-button', () => {
expect(detailsCssContent).toContain("html[it-join='remove_label'] #sponsor-button button .yt-spec-button-shape-next__button-text-content");
});

test('should remove label from new sponsorships renderer', () => {
expect(detailsCssContent).toContain("html[it-join='remove_label'] ytd-sponsorships-offer-module-renderer button .yt-spec-button-shape-next__button-text-content");
});
});
Loading