fix: Livechat visibility when foreced-theater mode is on #3843
Open
Jeetgajeraa wants to merge 3 commits into
Open
fix: Livechat visibility when foreced-theater mode is on #3843Jeetgajeraa wants to merge 3 commits into
Jeetgajeraa wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Addresses issue #3842 by adjusting sidebar/live chat layout so the chat is not obscured in theater mode when forced_theater_mode is enabled.
Changes:
- Update live chat/sidebar CSS to use a viewport-based height in forced theater mode.
- Ensure the live chat frame becomes vertically scrollable under the new sizing rules.
- When disabling “increase/decrease speed buttons”, also remove the related “1x” speed button.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| js&css/web-accessible/core.js | Removes the it-1x-speed-button when the speed button feature is disabled. |
| js&css/extension/www.youtube.com/appearance/sidebar/sidebar.css | Adds forced-theater-mode live chat sizing/scroll rules intended to prevent chat clipping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+195
to
+201
| html[it-forced-theater-mode='true'][data-page-type='video'] ytd-watch-flexy #secondary, | ||
| html[it-forced-theater-mode='true'][data-page-type='video'] ytd-watch-flexy #secondary-inner, | ||
| html[it-forced-theater-mode='true'][data-page-type='video'] ytd-watch-flexy #chat-container, | ||
| html[it-forced-theater-mode='true'][data-page-type='video'] ytd-watch-flexy ytd-live-chat-frame#chat { | ||
| /* Dynamic viewport height works better on mobile */ | ||
| height: calc(100dvh - max(56px, 7vh)) !important; | ||
| max-height: calc(100dvh - max(56px, 7vh)) !important; |
Jeetgajeraa
changed the title
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
issue #3842
Improve live chat visibility in YouTube theater mode, especially when
forced_theater_modeis enabled.What changed
sidebar.cssso it applies consistently across video pages.Testing
forced_theater_modeenabled.