-
Notifications
You must be signed in to change notification settings - Fork 6
Undo the Codebuild Pull Request Regex hack #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Undo the Codebuild Pull Request Regex hack #107
Conversation
…build set-e was in a stand-alone script bullet so it didn't carry down
post_build: | ||
commands: | ||
- echo "Verifying build success before moving on: $CODEBUILD_BUILD_SUCCEEDING" | ||
- | | ||
if [ "$CODEBUILD_BUILD_SUCCEEDING" != "1" ]; then | ||
echo "Previous phase failed; aborting post_build" | ||
exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never seen this before, what makes it necessary?
Properties: | ||
Handler: index.handler | ||
Runtime: python3.9 | ||
InlineCode: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a duplicate of "cicd/2-cicd/authorizer.py"? Should we be loading that file instead of inlining it here?
coverage==7.3.2 | ||
scikit-learn~=1.3.2 | ||
boto3==1.34.30 | ||
moto==4.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use a separate requirements.txt for the authorizer, to avoid mixing cicd dependencies with app dependencies?
Description
I'm replacing the old “hard-coded GitHub actor regex” CodeBuild webhook hack with an AWS EventBridge → Lambda → CodeBuild flow.
On each pull‐request event:
StartBuild
on the PR-build CodeBuild project.Links
cicd/README.md
→ Pull Request Authorizer Hookcicd/2-cicd/cicd.template.yml
Testing story
event.json
matching the structure above.Follow-up work
PR Checklist
cicd/README.md
, CFN template).