Remove oob fallback and launchy liveness check #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes sense. The out-of-band approach isn't supported by Google anymore, correct? |
Correct - it's officially EOL'd by Google and results in a 400 error. Just updated the description on this PR, didn't realize I had only posted that info in my other PR. |
cat5inthecradle
approved these changes
May 14, 2025
|
Bumped the version, merging then doing a manual release. |
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The out of band Oauth method has been blocked by Google since Jan 1, 2023.
This PR removes the fallback to out of band authentication and the message instructing the user to export an oauth code environment variable, since it no longer works.
Also removes the launchy liveness check, since at least for some users, the liveness check always failed. This check also caused the local oauth server to fail, which ultimately made it impossible to log in. Without the Launchy check, the server will still be shut down after the success request is served.