Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 273 #278

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Issue 273 #278

wants to merge 4 commits into from

Conversation

aevix
Copy link

@aevix aevix commented Sep 9, 2020

I created a switch statement for changeLanguage method in App.vue file so when user clicks on different language it will also change the title property of the leaflet-control-zoom class. I only know English and Korean so I was able to translate those but the other languages I just googled it so I don't think it is accurate. There might be a more elegant solution than what I came up with but after reading deep into leaflet and i18n documentations this is the only thing I could think of.
Fixes #273

Changed b-form-select to b-dropdown for the SearchFilter.vue
change handwash class rule width from 70 to 80
@ghost
Copy link

ghost commented Sep 9, 2020

Hey there! 👋 This repository uses the Prettier code style.

You forgot to format these files in your pull request:

  • covid-19-support/src/App.vue
  • covid-19-support/src/components/InfoPanel.vue
  • covid-19-support/src/components/ResourceMap.vue
  • covid-19-support/src/components/SearchFilters.vue

The Prettier installation guide
is a good place to get started with formatting your code properly. Thanks!!

❤️

Your friendly Prettifier bot

@readingdancer
Copy link
Contributor

Hi @aevix - Thank you again, same message below in case you see this one first:

I am trying to bring this project back to life as I rather dropped the ball last summer and no one else seemed to be interested to catch it. I am going to see if I can get the current PR's either merged in or closed so we have a clean slate, hence my updating the PR's now and I will start looking at them tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom in and out icon's "title" should be translatable.
2 participants