Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 262 #284

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jasonajones73
Copy link
Collaborator

Issue 262

What was done

This pull request does not completely close the issue but it should serve as a starting point. I got rid of axios and I am just using a fetch call now. I have a working fetch call to the REST API endpoint https://nccovid.vizioz.com/api/v1/resource/settings. The call is initiated on the created lifecycle hook for the SearchFilters.vue component. The categories response is stored in the components data object as cmsCategories.

To solve the CORS issue I mentioned before, I am proxying the request through https://cors-anywhere.herokuapp.com/. You should be able to see that in the fetch call.

What was not done

I did not integrate the response into the selection box because it seems like the response does not include everything that is currently in the constants.js object that is currently being imported to populate the selection box. Specifically, it is the code item in the categories and subcategories that is missing (For example: code: 'restaurant'). This is causing an issue with the needOptionGroups computed value.

@readingdancer
Copy link
Contributor

Thanks @jasonajones73 - Sorry for the delay, I will try and take a look at this at some time this week :)

@readingdancer
Copy link
Contributor

Hi @jasonajones73 - Really sorry I didn't get to properly look at this back in September, homeschooling of my children and hectic life in general took over my life and I dropped the ball on the NC COVID site. I am looking to try and finish what we started with the Umbraco implementation, so I will try and take a look at your PR this week. I have just automatically updated your branch to reflect other updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants