Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Oct 30, 2025

Part of #888. I'm splitting up integration of the new logger implemented in #1129 across multiple PRs. I've started with the @code-pushup/ci package.

This PR also includes a simple testing setup. Logger methods are spied on to enable assertions like expect(logger.info).toHaveBeenCalledWith('...'). By default, all logs are silenced. However, they will be printed if the test target is run with --verbose.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils 🛠️ tooling 🧩 ci labels Oct 30, 2025
@nx-cloud
Copy link

nx-cloud bot commented Oct 30, 2025

View your CI Pipeline Execution ↗ for commit 4293291

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 55s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 1m 5s View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 3m 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-30 09:59:34 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1132

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1132

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1132

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1132

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1132

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1132

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1132

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1132

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1132

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1132

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1132

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1132

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1132

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1132

commit: 4293291

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit b53f580 with previous commit 471c847.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 36 🔴 33 ↓ −3.5
Code coverage 🟢 90 🟢 90 ↑ +0.1
Documentation 🔴 36 🔴 36 ↓ −0.1
Security 🟡 56 🟡 56
Updates 🟡 73 🟡 73
Accessibility 🟢 92 🟢 92
Best Practices 🟢 97 🟢 97
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 3 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 36 🔴 33 ↓ −3.5
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1
JSDoc coverage Documentation coverage 🔴 36 🔴 36 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Total Blocking Time 🟥 1,510 ms 🟥 2,730 ms ↑ +80.2 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.3 s ↑ +5 %
Lighthouse Speed Index 🟥 7.5 s 🟥 7.3 s ↓ −2.5 %
JSDoc coverage Types coverage 🟥 242 undocumented types 🟥 242 undocumented types  +0 %
Code coverage Branch coverage 🟨 85.9 % 🟨 86 % ↑ +0.1 %
Code coverage Line coverage 🟨 86.8 % 🟨 86.8 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,028 KiB 🟩 Total size was 2,067 KiB ↑ +1.9 %
Lighthouse Minimizes main-thread work 🟥 10.8 s 🟥 15.4 s ↑ +42.8 %
Lighthouse JavaScript execution time 🟥 4.0 s 🟥 5.6 s ↑ +39.7 %
Lighthouse Server Backend Latencies 🟩 440 ms 🟩 1,380 ms ↑ +215 %
Lighthouse Largest Contentful Paint 🟥 11.6 s 🟥 12.3 s ↑ +6.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 103 KiB 🟥 Potential savings of 92 KiB ↓ −52.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 103 KiB 🟥 Potential savings of 89 KiB ↓ −68.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 180 KiB 🟥 Potential savings of 180 KiB ↓ −21.1 %
Lighthouse Avoids an excessive DOM size 🟥 2,295 elements 🟥 2,411 elements ↑ +5.1 %
Lighthouse Max Potential First Input Delay 🟥 1,550 ms 🟥 1,450 ms ↓ −6.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −0.5 %
Lighthouse Time to Interactive 🟥 13.9 s 🟥 13.8 s ↓ −0.5 %
Lighthouse Initial server response time was short 🟥 Root document took 690 ms 🟥 Root document took 730 ms ↑ +5.9 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 70 ms ↑ +36.7 %

589 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review October 30, 2025 09:53
@matejchalk matejchalk merged commit 6f134e6 into main Oct 30, 2025
23 checks passed
@matejchalk matejchalk deleted the new-logger-in-ci branch October 30, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 ci 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling 🧩 utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants