Skip to content

Extend test matrix to cover all supported ruby versions #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Extend test matrix to cover all supported ruby versions #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c43e606
Extend test matrix to cover all supported ruby versions
Taucher2003 Nov 24, 2024
9b7f7a1
Update required ruby version to match actual state
Taucher2003 Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ jobs:
strategy:
matrix:
ruby:
- '3.1.2' # using 3.1.2 instead of latest patch as 3.1.2 is the minimum specified in the gemspec
- '3.2.2'
- '3.3.6'

steps:
- uses: actions/checkout@v4
Expand Down
5 changes: 4 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require:
- rubocop-rspec

AllCops:
TargetRubyVersion: 3.0.0
TargetRubyVersion: 3.1.2
NewCops: enable

Gemspec/DevelopmentDependencies:
Expand Down Expand Up @@ -38,6 +38,9 @@ RSpec/ExampleLength:
Style/Documentation:
Enabled: false

Style/HashSyntax:
EnforcedShorthandSyntax: never

RSpec/MultipleMemoizedHelpers:
Enabled: false
RSpec/MultipleExpectations:
Expand Down
2 changes: 1 addition & 1 deletion code0-identities.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
spec.summary = "Library to manage external identities"
spec.homepage = "https://github.com/code0-tech/code0-identities"
spec.license = "MIT"
spec.required_ruby_version = ">= 3.0.0"
spec.required_ruby_version = ">= 3.1.2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually not compatible with 3.0.0 as you can see in this job: https://github.com/code0-tech/code0-identities/actions/runs/11991605452/job/33430499168

multi_xml-0.7.1 requires ruby version >= 3.1.2, which is incompatible with the current version, 3.0.0


spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = spec.homepage
Expand Down