Merge pull request #523 from code0-tech/420-flow-type-structure-fixes

Flow type structure fixes

Author: Taucher2003

app/graphql/types/data_type_identifier_type.rb

@@ -1,23 +1,18 @@
 # frozen_string_literal: true
 
 module Types
-  class DataTypeIdentifierType < Types::BaseUnion
+  class DataTypeIdentifierType < Types::BaseObject
     description 'Represents a data type identifier.'
 
-    possible_types Types::GenericTypeType, Types::DataTypeType, Types::GenericKeyType,
-                   description: 'The identifier can be a generic type, a data type, or a generic key.'
+    field :data_type, Types::DataTypeType, null: true, description: 'The data type of the data type identifier.'
 
-    def self.resolve_type(object, _context)
-      case object
-      when GenericType
-        Types::GenericTypeType
-      when DataType
-        Types::DataTypeType
-      when GenericKey
-        Types::GenericKeyType
-      else
-        raise "Unexpected value type: #{object.class}"
-      end
-    end
+    # rubocop:disable GraphQL/ExtractType -- generic_key and generic_type don't have anything in common
+    field :generic_key, String, null: true, description: 'The generic key of the data type identifier.'
+    field :generic_type, Types::GenericTypeType, null: true,
+                                                 description: 'The generic type of the data type identifier.'
+    # rubocop:enable GraphQL/ExtractType
+
+    id_field DataTypeIdentifier
+    timestamps
   end
 end

app/graphql/types/data_type_rule_type.rb

@@ -10,6 +10,7 @@ class DataTypeRuleType < Types::BaseObject
     field :config, Types::DataTypeRules::ConfigType, null: false,
                                                      description: 'The configuration of the rule'
 
+    id_field ::DataTypeRule
     timestamps
 
     def config

app/graphql/types/data_type_rules/config_type.rb

@@ -6,22 +6,26 @@ class ConfigType < Types::BaseUnion
       description 'Represents a rule that can be applied to a data type.'
 
       possible_types ContainsKeyConfigType, ContainsTypeConfigType, NumberRangeConfigType, ItemOfCollectionConfigType,
-                     RegexConfigType
+                     RegexConfigType, InputTypesConfigType, ReturnTypeConfigType
 
       def self.resolve_type(object, _context)
         case object[:variant]
         when :contains_key
-          Types::DataTypeRuleContainsKeyType
+          Types::DataTypeRules::ContainsKeyConfigType
         when :contains_type
-          Types::DataTypeRuleContainsTypeType
+          Types::DataTypeRules::ContainsTypeConfigType
         when :number_range
-          Types::DataTypeRuleNumberRangeType
+          Types::DataTypeRules::NumberRangeConfigType
         when :item_of_collection
-          Types::DataTypeRuleItemOfCollectionType
+          Types::DataTypeRules::ItemOfCollectionConfigType
         when :regex
-          Types::DataTypeRuleRegexType
+          Types::DataTypeRules::RegexConfigType
+        when :input_types
+          Types::DataTypeRules::InputTypesConfigType
+        when :return_type
+          Types::DataTypeRules::ReturnTypeConfigType
         else
-          raise GraphQL::ExecutionError, "Unknown data type rule variant: #{object.variant}"
+          raise GraphQL::ExecutionError, "Unknown data type rule variant: #{object[:variant]}"
         end
       end
     end

app/graphql/types/data_type_rules/contains_key_config_type.rb

@@ -5,7 +5,7 @@ module DataTypeRules
     class ContainsKeyConfigType < Types::BaseObject
       description 'Represents a rule that can be applied to a data type.'
 
-      authorize :read_flow
+      authorize :read_datatype
 
       field :data_type_identifier, Types::DataTypeIdentifierType,
             null: false, description: 'The identifier of the data type this rule belongs to'

app/graphql/types/data_type_rules/contains_type_config_type.rb

@@ -5,7 +5,7 @@ module DataTypeRules
     class ContainsTypeConfigType < Types::BaseObject
       description 'Represents a rule that can be applied to a data type.'
 
-      authorize :read_flow
+      authorize :read_datatype
 
       field :data_type_identifier, Types::DataTypeIdentifierType,
             null: false, description: 'The identifier of the data type this rule belongs to'

app/graphql/types/data_type_rules/input_type_config_type.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module Types
+  module DataTypeRules
+    class InputTypeConfigType < Types::BaseObject
+      description 'Represents a subtype of input type configuration for a input data type.'
+
+      authorize :read_datatype
+
+      field :data_type_identifier, Types::DataTypeIdentifierType,
+            null: false, description: 'The identifier of the data type this input type belongs to'
+
+      field :input_type, Types::DataTypeType,
+            null: false, description: 'The input data type that this configuration applies to'
+    end
+  end
+end

app/graphql/types/data_type_rules/input_types_config_type.rb

@@ -5,7 +5,10 @@ module DataTypeRules
     class InputTypesConfigType < Types::BaseObject
       description 'Represents a rule that can be applied to a data type.'
 
-      authorize :read_flow
+      authorize :read_datatype
+
+      field :input_types, [Types::DataTypeRules::InputTypeConfigType],
+            null: false, description: 'The input types that can be used in this data type rule'
     end
   end
 end

app/graphql/types/data_type_rules/item_of_collection_config_type.rb

@@ -5,7 +5,7 @@ module DataTypeRules
     class ItemOfCollectionConfigType < Types::BaseObject
       description 'Represents a rule that can be applied to a data type.'
 
-      authorize :read_flow
+      authorize :read_datatype
 
       field :items, [GraphQL::Types::JSON], null: true,
                                             description: 'The items that can be configured for this rule.'

app/graphql/types/data_type_rules/number_range_config_type.rb

@@ -5,7 +5,7 @@ module DataTypeRules
     class NumberRangeConfigType < Types::BaseObject
       description 'Represents a rule that can be applied to a data type.'
 
-      authorize :read_flow
+      authorize :read_datatype
 
       field :from, Integer, null: false,
                             description: 'The minimum value of the range'

app/graphql/types/data_type_rules/regex_config_type.rb

@@ -5,7 +5,7 @@ module DataTypeRules
     class RegexConfigType < Types::BaseObject
       description 'Represents a rule that can be applied to a data type.'
 
-      authorize :read_flow
+      authorize :read_datatype
 
       field :pattern, String, null: false,
                               description: 'The regex pattern to match against the data type value.'