Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ch. 12 problem #40

Merged
merged 8 commits into from
Nov 9, 2020
Merged

Add Ch. 12 problem #40

merged 8 commits into from
Nov 9, 2020

Conversation

neha-peddinti
Copy link
Contributor

Food Class
Ch. 12
Inheritance

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No linting violations have been found in this PR.

@phrdang phrdang requested review from a team and srikar-eranky and removed request for a team August 4, 2020 18:04
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No linting violations have been found in this PR.

@phrdang phrdang dismissed github-actions[bot]’s stale review August 4, 2020 21:25

flake8 rule E203 has an issue where it isn't PEP8 compliant (Black is correct)

@phrdang
Copy link
Member

phrdang commented Aug 4, 2020

@neha-peddinti please ignore the flake8 saying that the list slicing is wrong. flake8 is wrong, there's a bug in rule E203 that's being fixed.

Rules
flake8 Rule E203: PyCQA/pycodestyle#373
Black slicing rules: https://black.readthedocs.io/en/stable/the_black_code_style.html#slices

flake8 GitHub
Issue: PyCQA/pycodestyle#373
PR: PyCQA/pycodestyle#914

@phrdang phrdang requested review from a team and Miserabl and removed request for a team August 4, 2020 21:27
Copy link
Contributor

@abhatia1205 abhatia1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great problem! Only a few tweaks are required. First of all, when you call Food.__init__(self, *args), the self keyword is not supposed to be passed. Also, it is better coding practice to use the super() function instead of the name of the actual class, Food. This being said, if the students aren't yet supposed to have learned about the super function, I totally get that too.

Nice work!

2_intermediate/chapter12/solutions/food_class.py Outdated Show resolved Hide resolved
2_intermediate/chapter12/solutions/food_class.py Outdated Show resolved Hide resolved
2_intermediate/chapter12/solutions/food_class.py Outdated Show resolved Hide resolved
neha-peddinti and others added 2 commits August 4, 2020 17:48
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No linting violations have been found in this PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

Co-authored-by: abhatia1205 <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No linting violations have been found in this PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No linting violations have been found in this PR.

Copy link
Contributor

@srikar-eranky srikar-eranky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Citrus716 Citrus716 merged commit 57eca2e into master Nov 9, 2020
@Citrus716 Citrus716 deleted the neha-add-exercises branch November 9, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants