-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ch. 12 problem #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No linting violations have been found in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No linting violations have been found in this PR.
flake8 rule E203 has an issue where it isn't PEP8 compliant (Black is correct)
@neha-peddinti please ignore the flake8 saying that the list slicing is wrong. flake8 is wrong, there's a bug in rule E203 that's being fixed. Rules flake8 GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great problem! Only a few tweaks are required. First of all, when you call Food.__init__(self, *args)
, the self
keyword is not supposed to be passed. Also, it is better coding practice to use the super()
function instead of the name of the actual class, Food
. This being said, if the students aren't yet supposed to have learned about the super
function, I totally get that too.
Nice work!
Co-authored-by: abhatia1205 <[email protected]>
Co-authored-by: abhatia1205 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No linting violations have been found in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lintly has detected code quality issues in this pull request.
Co-authored-by: abhatia1205 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No linting violations have been found in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No linting violations have been found in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Food Class
Ch. 12
Inheritance