Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T04 Code Review #1

Open
wants to merge 14 commits into
base: feedback
Choose a base branch
from
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,6 @@ testem.log
# System files
.DS_Store
Thumbs.db

# Data base
data/
29 changes: 5 additions & 24 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,8 @@
# ContactsAppAngular

This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 17.2.0.
## Dev

## Development server

Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The application will automatically reload if you change any of the source files.

## Code scaffolding

Run `ng generate component component-name` to generate a new component. You can also use `ng generate directive|pipe|service|class|guard|interface|enum|module`.

## Build

Run `ng build` to build the project. The build artifacts will be stored in the `dist/` directory.

## Running unit tests

Run `ng test` to execute the unit tests via [Karma](https://karma-runner.github.io).

## Running end-to-end tests

Run `ng e2e` to execute the end-to-end tests via a platform of your choice. To use this command, you need to first add a package that implements end-to-end testing capabilities.

## Further help

To get more help on the Angular CLI use `ng help` or go check out the [Angular CLI Overview and Command Reference](https://angular.io/cli) page.
1. Clonar el proyecto
2. Ejecutar `npm install`
3. Levantar backend `npm run backend`
4. Ejecutar la app `npm start` o `ng serve -o`
1 change: 1 addition & 0 deletions assets/icons/angular.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
248 changes: 248 additions & 0 deletions data/db-back.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,248 @@
{
"contacts": [
{
"id": "alex-anderson",
"avatar_url": "https://sessionize.com/image/df38-400o400o2-JwbChVUj6V7DwZMc9vJEHc.jpg",
"name": "Alex",
"lastname": "Anderson",
"twitter_username": "@ralex1993",
"favorite": false,
"note": "Friend from college."
},
{
"id": "giovanni-benussi",
"avatar_url": "https://sessionize.com/image/08be-400o400o2-WtYGFFR1ZUJHL9tKyVBNPV.jpg",
"name": "Giovanni",
"lastname": "Benussi",
"twitter_username": "@giovannibenussi",
"favorite": false,
"note": "Gym buddy."
},
{
"id": "paul-bratslavsky",
"avatar_url": "https://sessionize.com/image/feba-400o400o2-R4GE7eqegJNFf3cQ567obs.jpg",
"name": "Paul",
"lastname": "Bratslavsky",
"twitter_username": "@codingthirty",
"favorite": false,
"note": "Gym buddy."
},
{
"id": "pedro-cattori",
"avatar_url": "https://sessionize.com/image/c315-400o400o2-spjM5A6VVfVNnQsuwvX3DY.jpg",
"name": "Pedro",
"lastname": "Cattori",
"twitter_username": "@pcattori",
"favorite": false,
"note": "Friend from college."
},
{
"id": "christopher-chedeau",
"avatar_url": "https://sessionize.com/image/b07e-400o400o2-KgNRF3S9sD5ZR4UsG7hG4g.jpg",
"name": "Christopher",
"lastname": "Chedeau",
"twitter_username": "@Vjeux",
"favorite": false,
"note": "Friend from college."
},
{
"id": "kent c.-dodds",
"avatar_url": "https://sessionize.com/image/5578-400o400o2-BMT43t5kd2U1XstaNnM6Ax.jpg",
"name": "Kent C.",
"lastname": "Dodds",
"twitter_username": "@kentcdodds",
"favorite": false,
"note": "Friend from college."
},
{
"id": "clifford-fajardo",
"avatar_url": "https://sessionize.com/image/30f1-400o400o2-wJBdJ6sFayjKmJycYKoHSe.jpg",
"name": "Clifford",
"lastname": "Fajardo",
"twitter_username": "@cliffordfajard0",
"favorite": false,
"note": "Friend from college."
},
{
"id": "ryan-florence",
"avatar_url": "https://sessionize.com/image/9273-400o400o2-3tyrUE3HjsCHJLU5aUJCja.jpg",
"name": "Ryan",
"lastname": "Florence",
"note": "Friend from college."
},
{
"id": "arisa-fukuzaki",
"avatar_url": "https://sessionize.com/image/fcda-400o400o2-XiYRtKK5Dvng5AeyC8PiUA.png",
"name": "Arisa",
"lastname": "Fukuzaki",
"twitter_username": "@arisa_dev",
"favorite": false,
"note": "Met at the conference."
},
{
"id": "edmund-hung",
"avatar_url": "https://sessionize.com/image/6aeb-400o400o2-Q5tAiuzKGgzSje9ZsK3Yu5.JPG",
"name": "Edmund",
"lastname": "Hung",
"twitter_username": "@_edmundhung",
"favorite": false,
"note": "Friend from college."
},
{
"id": "jon-jensen",
"avatar_url": "https://sessionize.com/image/6644-400o400o2-aHnGHb5Pdu3D32MbfrnQbj.jpg",
"name": "Jon",
"lastname": "Jensen",
"twitter_username": "@jenseng",
"favorite": false,
"note": ""
},
{
"id": "cat-johnson",
"avatar_url": "https://sessionize.com/image/7594-400o400o2-hWtdCjbdFdLgE2vEXBJtyo.jpg",
"name": "Cat",
"lastname": "Johnson",
"favorite": false,
"note": ""
},
{
"id": "shruti-kapoor",
"avatar_url": "https://sessionize.com/image/124e-400o400o2-wHVdAuNaxi8KJrgtN3ZKci.jpg",
"name": "Shruti",
"lastname": "Kapoor",
"twitter_username": "@shrutikapoor08",
"favorite": false,
"note": ""
},
{
"id": "brandon-kish",
"avatar_url": "https://sessionize.com/image/fb82-400o400o2-LbvwhTVMrYLDdN3z4iEFMp.jpeg",
"name": "Brandon",
"lastname": "Kish",
"favorite": false,
"note": ""
},
{
"id": "andre-landgraf",
"avatar_url": "https://sessionize.com/image/eec1-400o400o2-HkvWKLFqecmFxLwqR9KMRw.jpg",
"name": "Andre",
"lastname": "Landgraf",
"twitter_username": "@AndreLandgraf94"
},
{
"id": "brian-lee",
"avatar_url": "https://sessionize.com/image/cef7-400o400o2-KBZUydbjfkfGACQmjbHEvX.jpeg",
"name": "Brian",
"lastname": "Lee",
"twitter_username": "@brian_dlee",
"favorite": false,
"note": ""
},
{
"id": "brooks-lybrand",
"avatar_url": "https://sessionize.com/image/820b-400o400o2-Ja1KDrBAu5NzYTPLSC3GW8.jpg",
"name": "Brooks",
"lastname": "Lybrand",
"twitter_username": "@BrooksLybrand",
"favorite": false,
"note": ""
},
{
"id": "cameron-matheson",
"avatar_url": "https://sessionize.com/image/262f-400o400o2-UBPQueK3fayaCmsyUc1Ljf.jpg",
"name": "Cameron",
"lastname": "Matheson",
"twitter_username": "@cmatheson",
"favorite": false,
"note": ""
},
{
"id": "sean-mcquaid",
"avatar_url": "https://sessionize.com/image/f83b-400o400o2-Pyw3chmeHMxGsNoj3nQmWU.jpg",
"name": "Sean",
"lastname": "McQuaid",
"twitter_username": "@SeanMcQuaidCode",
"favorite": false,
"note": ""
},
{
"id": "igor-minar",
"avatar_url": "https://sessionize.com/image/f814-400o400o2-n2ua5nM9qwZA2hiGdr1T7N.jpg",
"name": "Igor",
"lastname": "Minar",
"twitter_username": "@IgorMinar"
},
{
"id": "ashley-narcisse",
"avatar_url": "https://sessionize.com/image/5636-400o400o2-TWgi8vELMFoB3hB9uPw62d.jpg",
"name": "Ashley",
"lastname": "Narcisse",
"twitter_username": "@_darkfadr",
"favorite": false,
"note": ""
},
{
"id": "oscar-newman",
"avatar_url": "https://sessionize.com/image/d14d-400o400o2-pyB229HyFPCnUcZhHf3kWS.png",
"name": "Oscar",
"lastname": "Newman",
"twitter_username": "@__oscarnewman"
},
{
"id": "andrew-petersen",
"avatar_url": "https://sessionize.com/image/2694-400o400o2-MYYTsnszbLKTzyqJV17w2q.png",
"name": "Andrew",
"lastname": "Petersen"
},
{
"id": "monica-powell",
"avatar_url": "https://sessionize.com/image/c73a-400o400o2-4MTaTq6ftC15hqwtqUJmTC.jpg",
"name": "Monica",
"lastname": "Powell",
"twitter_username": "@indigitalcolor"
},
{
"id": "glenn-reyes",
"avatar_url": "https://sessionize.com/image/1940-400o400o2-Enh9dnYmrLYhJSTTPSw3MH.jpg",
"name": "Glenn",
"lastname": "Reyes",
"twitter_username": "@glnnrys"
},
{
"id": "nevi-shah",
"avatar_url": "https://sessionize.com/image/c9d5-400o400o2-Sri5qnQmscaJXVB8m3VBgf.jpg",
"name": "Nevi",
"lastname": "Shah",
"twitter_username": "@nevikashah"
},
{
"id": "scott-smerchek",
"avatar_url": "https://sessionize.com/image/907a-400o400o2-9TM2CCmvrw6ttmJiTw4Lz8.jpg",
"name": "Scott",
"lastname": "Smerchek",
"twitter_username": "@smerchek"
},
{
"id": "alexandra-spalato",
"avatar_url": "https://sessionize.com/image/c8c3-400o400o2-PR5UsgApAVEADZRixV4H8e.jpeg",
"name": "Alexandra",
"lastname": "Spalato",
"twitter_username": "@alexadark"
},
{
"id": "erick-tamayo",
"avatar_url": "https://sessionize.com/image/6faa-400o400o2-amseBRDkdg7wSK5tjsFDiG.jpg",
"name": "Erick",
"lastname": "Tamayo",
"twitter_username": "@ericktamayo",
"favorite": false
},
{
"id": "shane-walker",
"avatar_url": "https://sessionize.com/image/a9fc-400o400o2-JHBnWZRoxp7QX74Hdac7AZ.jpg",
"name": "Shane",
"lastname": "Walker",
"twitter_username": "@swalker326"
}
]
}
Loading