WIP

codebar-ag · May 18, 2023 · eba7ecd · eba7ecd
1 parent 3a0861a
commit eba7ecd
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 14 deletions.
diff --git a/config/flatfox.php b/config/flatfox.php
@@ -2,7 +2,6 @@
 
 return [
 
-    'token' => env('FLATFOX_TOKEN'),
-    'public_listing_identifier' => env('FLATFOX_PUBLIC_LISTING_IDENTIFIER'),
-
+    'timeout' => env('FLATFOX_TIMEOUT', 15),
+    'caching' => env('FLATFOX_CACHING', 1),
 ];
diff --git a/src/DTO/Listing.php b/src/DTO/Listing.php
@@ -61,9 +61,9 @@ public function __construct(
         public string|null $website_url,
         public string|null $live_viewing_url,
         public int|null $cover_image,
-        public null $images,
-        public null $documents,
-        public null $agency,
+        public Collection|null $images,
+        public Collection|null $documents,
+        public Agency|null $agency,
         public bool $reserved,
         public string|null $rent_title,
         public int|null $livingspace,
@@ -127,8 +127,8 @@ public static function fromJson(array $data): self
             website_url: Arr::get($data, 'website_url'),
             live_viewing_url: Arr::get($data, 'live_viewing_url'),
             cover_image: Arr::get($data, 'cover_image'),
-            images: Arr::has($data, 'images') ? self::attributes(Arr::get($data, 'images')) : null,
-            documents: Arr::has($data, 'documents') ? self::attributes(Arr::get($data, 'documents')) : null,
+            images: Arr::has($data, 'images') ? self::images(Arr::get($data, 'images')) : null,
+            documents: Arr::has($data, 'documents') ? self::documents(Arr::get($data, 'documents')) : null,
             agency: Arr::has($data, 'agency') ? Agency::fromJson(Arr::get($data, 'agency')) : null,
             reserved: Arr::get($data, 'reserved'),
             rent_title: Arr::get($data, 'rent_title'),

diff --git a/src/Requests/GetPublicListing.php b/src/Requests/GetPublicListing.php
@@ -45,7 +45,7 @@ public function createDtoFromResponse(Response $response): mixed
     protected function defaultConfig(): array
     {
         return [
-            'timeout' => 15,
+            'timeout' => config('flatfox.caching', 15),
         ];
     }
 
@@ -56,6 +56,6 @@ public function resolveCacheDriver(): Driver
 
     public function cacheExpiryInSeconds(): int
     {
-        return 1;
+        return config('flatfox.caching', 1);
     }
 }
diff --git a/tests/Feature/GetPublicListingTest.php b/tests/Feature/GetPublicListingTest.php
@@ -11,14 +11,13 @@
     $forge = new FlatfoxConnector();
     $request = new GetPublicListing(142, '&expand=documents&expand=images');
     $response = $forge->send($request);
-
-    ray($response->json());
 })
-    ->group('get', 'public-listing');
+    ->group('get', 'public-listing')
+    ->skip();
 
 it('get public listing', function () {
     $mockClient = new MockClient([
         GetPublicListing::class => MockResponse::fixture('singleServer'),
     ]);
 })
-    ->group('get', 'public-listing')->todo();
+    ->group('get', 'public-listing')->skip();