Add Guzzle Timeout To Prerender Middleware #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds new `prerender.timeout` config option. Defaults to no timeout
|
@StanBarrows bump, if you have time for this |
|
@kellerjmrtn V11.1 is published thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #38
Since the constructor was already updating guzzle config for
allow_redirects, I decided to use the same idea fortimeout. Potentially a breaking change since a new Guzzle client is created every time now, although I doubt that's too significant? I've also maintained throwing exceptions in debug mode for bothRequestExceptionand the newConnectExceptionRan
composer formatwhich added a few extra small whitespace changes. Let me know if the additional test and readme changes are enough