fix: data-testid test (#4302)

codeceptjs · Apr 16, 2024 · 73f38dc · 73f38dc
1 parent 536c1bc
commit 73f38dc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/locator.js b/lib/locator.js
@@ -541,7 +541,7 @@ function removePrefix(xpath) {
  * @returns {boolean}
  */
 function isPlaywrightLocator(locator) {
-  return locator.includes('_react') || locator.includes('_vue') || locator.includes('data-testid');
+  return locator.includes('_react') || locator.includes('_vue');
 }
 
 /**

diff --git a/test/helper/Playwright_test.js b/test/helper/Playwright_test.js
@@ -1497,11 +1497,19 @@ describe('using data-testid attribute', () => {
     return I._after();
   });
 
-  it('should find element by data-testid attribute', async () => {
+  it('should find element by pw locator', async () => {
     await I.amOnPage('/');
 
     const webElements = await I.grabWebElements({ pw: '[data-testid="welcome"]' });
     assert.equal(webElements[0]._selector, '[data-testid="welcome"] >> nth=0');
     assert.equal(webElements.length, 1);
   });
+
+  it('should find element by h1[data-testid="welcome"]', async () => {
+    await I.amOnPage('/');
+
+    const webElements = await I.grabWebElements('h1[data-testid="welcome"]');
+    assert.equal(webElements[0]._selector, 'h1[data-testid="welcome"] >> nth=0');
+    assert.equal(webElements.length, 1);
+  });
 });