Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get maturin ci passing completely #56

Merged
merged 1 commit into from
Sep 26, 2024
Merged

get maturin ci passing completely #56

merged 1 commit into from
Sep 26, 2024

Conversation

matt-codecov
Copy link
Collaborator

@matt-codecov matt-codecov commented Sep 25, 2024

since the last release attempt, maturin v1.7.2 came out which has a regression that impacts us. also i missed a windows issue (apparently my windows env doesn't have autocrlf enabled). this PR fixes both issues

i tested by adding a pull_request trigger which i've now removed. here's a run where everything passed https://github.com/codecov/codecov-rs/actions/runs/11041921939

a full recounting of release problems:

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (eaeaf7a) to head (edc0d3e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files          21       21           
  Lines        6775     6775           
=======================================
  Hits         6676     6676           
  Misses         99       99           
Components Coverage Δ
core 98.61% <ø> (ø)
bindings 79.31% <ø> (ø)
python 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov matt-codecov force-pushed the pr56 branch 6 times, most recently from 7917cd7 to 168caa9 Compare September 25, 2024 22:13
@matt-codecov matt-codecov marked this pull request as ready for review September 25, 2024 22:18
@matt-codecov matt-codecov merged commit a189461 into main Sep 26, 2024
9 checks passed
@matt-codecov matt-codecov deleted the pr56 branch September 26, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants