fix: retry on version curl #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 2 2
Lines 35 35
=======================================
Hits 34 34
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thomasrockhu-codecov
requested changes
Mar 22, 2025
joseph-sentry
force-pushed
the
joseph
branch
2 times, most recently
from
a8de9b0 to
8d487ae
Compare
scripts/download.sh
Outdated
| @@ -42,11 +42,12 @@ else | |||
| codecov_url="$codecov_url/${CODECOV_VERSION}" | |||
| codecov_url="$codecov_url/${CODECOV_OS}/${codecov_filename}" | |||
| say "$g ->$x Downloading $b${codecov_url}$x" | |||
| curl -O --retry 5 --retry-delay 2 "$codecov_url" | |||
| r="--retry 5 --retry-delay 2" | |||
There was a problem hiding this comment.
you can probably pull this into set_defaults and use it in validate.sh also.
I would also name it something a little longer, r, might be used in a user's env vars already perhaps
|
bump @joseph-sentry |
we do retry-all-errors as an attempt to catch exit code 56 errors
thomasrockhu-codecov
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we do retry-all-errors as an attempt to catch exit code 56 errors