Skip to content

⚡️ Speed up method PrivacyManager.get_scope by 18% #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method PrivacyManager.get_scope by 18% #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions nvflare/private/privacy_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,29 +68,31 @@ def add_task_result_filter(self, f: Filter, direction):

class PrivacyManager(object):
def __init__(
self, scopes: Union[None, List[Scope]], default_scope_name: Union[None, str], components: Union[None, dict]
self, scopes: Union[None, List["Scope"]], default_scope_name: Union[None, str], components: Union[None, dict]
):
self.name_to_scopes = {}
self.default_scope = None
self.components = components

if scopes:
# Use local variable for improved attribute access performance
name_to_scopes = self.name_to_scopes
for s in scopes:
if s.name in self.name_to_scopes:
raise ValueError(f"duplicate scopes defined for name '{s.name}'")
self.name_to_scopes[s.name] = s
name = s.name
if name in name_to_scopes:
raise ValueError(f"duplicate scopes defined for name '{name}'")
name_to_scopes[name] = s
if default_scope_name:
self.default_scope = self.name_to_scopes.get(default_scope_name)
if not self.default_scope:
default_scope = name_to_scopes.get(default_scope_name)
if not default_scope:
raise ValueError(f"specified default scope '{default_scope_name}' does not exist")
self.default_scope = default_scope
self.policy_defined = True
else:
self.policy_defined = False

def get_scope(self, name: Union[None, str]):
if not name:
return self.default_scope

return self.name_to_scopes.get(name)

def is_policy_defined(self):
Expand Down