⚡️ Speed up function is_valid_project_name by 13%

[codeflash-ai]

📄 13% (0.13x) speedup for is_valid_project_name in framework/py/flwr/cli/utils.py

⏱️ Runtime : 20.0 milliseconds → 17.8 milliseconds (best of 128 runs)

📝 Explanation and details

The optimized version achieves a 12% speedup through two key micro-optimizations that reduce overhead in the performance-critical loop:

Key Optimizations:

1. Pre-bound method lookup: isalnum = str.isalnum eliminates repeated attribute lookups on str.isalnum inside the loop. Each call to char.isalnum() in the original code performs a method lookup, while the optimized version uses the pre-bound reference.

2. Set-based membership test: allowed_special = {'-'} replaces the string literal "-" for the char in operation. Set membership testing has slightly better performance characteristics than string membership for single-character lookups.

Performance Impact:
The line profiler shows the main loop (for char in name[1:]:) and validation check (if not (isalnum(char) or char in allowed_special):) account for ~97% of total runtime. Even small optimizations in this hot path compound significantly when processing many characters.

Test Case Effectiveness:
These optimizations are most beneficial for:

• Large-scale tests with many iterations (like test_large_scale_many_valid_names with 1000+ calls)
• Long string validation (like test_large_scale_long_names_with_hyphens_and_digits with 999-character strings)
• Unicode-heavy workloads where character validation is frequent

The optimizations preserve all behavioral guarantees while reducing per-character processing overhead in the validation loop.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	🔘 None Found
🌀 Generated Regression Tests	✅ 6285 Passed
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	✅ 4 Passed
📊 Tests Coverage	100.0%

🌀 Generated Regression Tests and Runtime

import pytest  # used for our unit tests
from cli.utils import is_valid_project_name

# unit tests

# ------------------------------
# Basic Test Cases
# ------------------------------

def test_valid_simple_names():
    # Valid project names: start with letter, contain letters/digits/hyphens
    codeflash_output = is_valid_project_name("project")
    codeflash_output = is_valid_project_name("Project123")
    codeflash_output = is_valid_project_name("my-project")
    codeflash_output = is_valid_project_name("A")  # single letter
    codeflash_output = is_valid_project_name("a1-b2-c3")

def test_invalid_simple_names():
    # Invalid project names: start with digit, contain invalid characters, empty
    codeflash_output = is_valid_project_name("")  # empty string
    codeflash_output = is_valid_project_name("1project")  # starts with digit
    codeflash_output = is_valid_project_name("-project")  # starts with hyphen
    codeflash_output = is_valid_project_name("project!")  # contains invalid character
    codeflash_output = is_valid_project_name("project name")  # contains space
    codeflash_output = is_valid_project_name("project_name")  # contains underscore

# ------------------------------
# Edge Test Cases
# ------------------------------

def test_edge_case_starting_characters():
    # Should only allow starting with a letter (a-z, A-Z)
    codeflash_output = is_valid_project_name("a")
    codeflash_output = is_valid_project_name("Z")
    codeflash_output = is_valid_project_name("0abc")
    codeflash_output = is_valid_project_name("-abc")
    codeflash_output = is_valid_project_name("_abc")
    codeflash_output = is_valid_project_name(" abc")

def test_edge_case_invalid_characters():
    # Should reject any character except letters, digits, and hyphens
    codeflash_output = is_valid_project_name("abc$")
    codeflash_output = is_valid_project_name("abc.def")
    codeflash_output = is_valid_project_name("abc@def")
    codeflash_output = is_valid_project_name("abc/def")
    codeflash_output = is_valid_project_name("abc\\def")
    codeflash_output = is_valid_project_name("abc:def")
    codeflash_output = is_valid_project_name("abc;def")
    codeflash_output = is_valid_project_name("abc,def")
    codeflash_output = is_valid_project_name("abc+def")
    codeflash_output = is_valid_project_name("abc=def")
    codeflash_output = is_valid_project_name("abc~def")
    codeflash_output = is_valid_project_name("abc`def")
    codeflash_output = is_valid_project_name("abc*def")
    codeflash_output = is_valid_project_name("abc?def")
    codeflash_output = is_valid_project_name("abc#def")
    codeflash_output = is_valid_project_name("abc[def]")
    codeflash_output = is_valid_project_name("abc{def}")
    codeflash_output = is_valid_project_name("abc|def")
    codeflash_output = is_valid_project_name("abc%def")
    codeflash_output = is_valid_project_name("abc^def")
    codeflash_output = is_valid_project_name("abc\"def")
    codeflash_output = is_valid_project_name("abc'def")

def test_edge_case_unicode():
    # Should allow Unicode letters and digits, but not non-letter/digit/dash
    codeflash_output = is_valid_project_name("Éclair")  # Unicode letter
    codeflash_output = is_valid_project_name("项目123")  # Chinese characters + digits
    codeflash_output = is_valid_project_name("Проект-1")  # Cyrillic + hyphen + digit
    codeflash_output = is_valid_project_name("αβγ-123")  # Greek letters + hyphen + digits
    codeflash_output = is_valid_project_name("项目@123")  # Chinese + invalid character
    codeflash_output = is_valid_project_name("Éclair!")  # Unicode letter + invalid char

def test_edge_case_hyphen_usage():
    # Hyphens are allowed anywhere except first character
    codeflash_output = is_valid_project_name("a-b-c")
    codeflash_output = is_valid_project_name("ab-cd-ef")
    codeflash_output = is_valid_project_name("-abc")
    codeflash_output = is_valid_project_name("abc-")  # trailing hyphen is allowed
    codeflash_output = is_valid_project_name("a--b")  # consecutive hyphens are allowed

def test_edge_case_length():
    # Test minimum and maximum reasonable lengths
    codeflash_output = is_valid_project_name("a")
    codeflash_output = is_valid_project_name("a" * 255)  # long name, all letters
    codeflash_output = is_valid_project_name("a" + "-" * 254)  # long name, mostly hyphens
    codeflash_output = is_valid_project_name("a" + "1" * 254)  # long name, letters+digits
    codeflash_output = is_valid_project_name("a" + "!" * 254)  # long name, invalid chars

def test_edge_case_only_hyphens():
    # Should not allow names that are only hyphens
    codeflash_output = is_valid_project_name("-")
    codeflash_output = is_valid_project_name("--")

def test_edge_case_whitespace():
    # Should not allow whitespace anywhere
    codeflash_output = is_valid_project_name("project name")
    codeflash_output = is_valid_project_name(" project")
    codeflash_output = is_valid_project_name("project ")
    codeflash_output = is_valid_project_name("proj ect")
    codeflash_output = is_valid_project_name("project\tname")
    codeflash_output = is_valid_project_name("project\nname")

# ------------------------------
# Large Scale Test Cases
# ------------------------------

def test_large_scale_valid_names():
    # Generate 1000 valid project names and check all are valid
    for i in range(1, 1001):
        name = f"Project{i}-valid"
        codeflash_output = is_valid_project_name(name)

def test_large_scale_invalid_names():
    # Generate 1000 invalid project names (start with digit) and check all are invalid
    for i in range(1, 1001):
        name = f"{i}InvalidProject"
        codeflash_output = is_valid_project_name(name)

def test_large_scale_all_hyphens():
    # Generate names with increasing number of hyphens (but starting with letter)
    for i in range(1, 1001):
        name = "a" + "-" * i
        codeflash_output = is_valid_project_name(name)

def test_large_scale_invalid_characters():
    # Names with invalid character at random positions
    invalid_chars = ["!", "@", "#", "$", "%", "^", "&", "*", "(", ")", " "]
    for i, char in enumerate(invalid_chars):
        name = f"Project{char}{i}"
        codeflash_output = is_valid_project_name(name)

def test_large_scale_unicode_names():
    # Valid names with Unicode letters and digits
    for i in range(1, 1001):
        name = f"项目{i}-测试"
        codeflash_output = is_valid_project_name(name)

def test_large_scale_max_length():
    # Test valid and invalid names at maximum reasonable length (255 chars)
    valid_name = "a" + "b" * 254
    invalid_name = "1" + "b" * 254
    codeflash_output = is_valid_project_name(valid_name)
    codeflash_output = is_valid_project_name(invalid_name)

# ------------------------------
# Determinism Test
# ------------------------------

def test_determinism():
    # The function should always return the same result for the same input
    name = "Project-Deterministic"
    codeflash_output = is_valid_project_name(name); result1 = codeflash_output
    codeflash_output = is_valid_project_name(name); result2 = codeflash_output

# ------------------------------
# Type Robustness Test
# ------------------------------


def test_case_sensitivity():
    # Should accept both upper and lower case letters
    codeflash_output = is_valid_project_name("project")
    codeflash_output = is_valid_project_name("PROJECT")
    codeflash_output = is_valid_project_name("Project-Name")
    codeflash_output = is_valid_project_name("pRoJeCt-123")
# codeflash_output is used to check that the output of the original code is the same as that of the optimized code.
#------------------------------------------------
import pytest  # used for our unit tests
from cli.utils import is_valid_project_name

# unit tests

# -------------------------
# 1. Basic Test Cases
# -------------------------

def test_valid_basic_names():
    # Valid names: start with letter, contain letters, digits, hyphens
    codeflash_output = is_valid_project_name("project")  # all letters
    codeflash_output = is_valid_project_name("project1")  # letters and digits
    codeflash_output = is_valid_project_name("project-1")  # letters, digits, hyphen
    codeflash_output = is_valid_project_name("a")  # single letter
    codeflash_output = is_valid_project_name("A")  # single uppercase letter
    codeflash_output = is_valid_project_name("my-project")  # letters and hyphen
    codeflash_output = is_valid_project_name("MyProject")  # mixed case

def test_invalid_basic_names():
    # Invalid names: empty, start with non-letter, contain invalid chars
    codeflash_output = is_valid_project_name("")  # empty string
    codeflash_output = is_valid_project_name("1project")  # starts with digit
    codeflash_output = is_valid_project_name("-project")  # starts with hyphen
    codeflash_output = is_valid_project_name("_project")  # starts with underscore
    codeflash_output = is_valid_project_name("project_1")  # contains underscore
    codeflash_output = is_valid_project_name("project!")  # contains exclamation
    codeflash_output = is_valid_project_name("project name")  # contains space
    codeflash_output = is_valid_project_name("project.name")  # contains dot

# -------------------------
# 2. Edge Test Cases
# -------------------------

def test_edge_case_first_char():
    # First char must be a letter, check all ASCII letters
    for c in "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ":
        codeflash_output = is_valid_project_name(f"{c}123")  # valid
        codeflash_output = is_valid_project_name(f"{c}-name")  # valid

    # First char is not a letter
    for c in "0123456789-_!.":
        codeflash_output = is_valid_project_name(f"{c}name")

def test_edge_case_hyphen_usage():
    # Hyphen allowed anywhere except first character
    codeflash_output = is_valid_project_name("a-b-c-d")
    codeflash_output = is_valid_project_name("abc-def-123")
    codeflash_output = is_valid_project_name("a-")  # ends with hyphen
    codeflash_output = is_valid_project_name("a--b")  # consecutive hyphens allowed

def test_edge_case_invalid_characters():
    # Invalid characters: underscore, space, punctuation, non-ASCII
    invalid_chars = "_ .!@#$%^&*()+=[]{}|;:'\",<>/?\\~`"
    for c in invalid_chars:
        codeflash_output = is_valid_project_name(f"a{c}b")

    # Non-ASCII letters (should fail, since isalpha only checks Unicode letters)
    codeflash_output = is_valid_project_name("añb")  # ñ is Unicode letter, allowed
    codeflash_output = is_valid_project_name("aβb")  # Greek beta, allowed
    codeflash_output = is_valid_project_name("a中b")  # Chinese character, allowed

def test_edge_case_length_limits():
    # Very short and very long names
    codeflash_output = is_valid_project_name("a")  # shortest valid
    codeflash_output = is_valid_project_name("a" * 1000)  # long valid name
    codeflash_output = is_valid_project_name("a" + "-" * 999)  # long with hyphens

def test_edge_case_only_hyphens_and_digits():
    # Names with only hyphens and digits are invalid (must start with letter)
    codeflash_output = is_valid_project_name("1-2-3")
    codeflash_output = is_valid_project_name("-1-2-3")
    codeflash_output = is_valid_project_name("a-1-2-3")

def test_edge_case_unicode_letters():
    # Unicode letters are allowed as first character
    codeflash_output = is_valid_project_name("ßproject")  # German sharp S
    codeflash_output = is_valid_project_name("Ωmega")  # Greek Omega
    codeflash_output = is_valid_project_name("中project")  # Chinese character

# -------------------------
# 3. Large Scale Test Cases
# -------------------------

def test_large_scale_many_valid_names():
    # Generate 1000 valid names and check all are valid
    for i in range(1, 1001):
        name = f"p{i}-name"
        codeflash_output = is_valid_project_name(name)

def test_large_scale_many_invalid_names():
    # Generate 1000 invalid names (start with digit)
    for i in range(1, 1001):
        name = f"{i}project"
        codeflash_output = is_valid_project_name(name)

def test_large_scale_long_names_with_hyphens_and_digits():
    # Long names with mixed hyphens and digits, starting with letter
    name = "a" + ("-1" * 499)  # total length: 1 + 2*499 = 999
    codeflash_output = is_valid_project_name(name)

def test_large_scale_long_names_with_invalid_char():
    # Long name with one invalid char in the middle
    name = "a" * 499 + "_" + "b" * 500
    codeflash_output = is_valid_project_name(name)

def test_large_scale_performance():
    # Test performance for large valid name (should not hang)
    name = "a" + ("b" * 999)
    codeflash_output = is_valid_project_name(name)

# -------------------------
# 4. Determinism and Mutation Safety
# -------------------------

def test_mutation_safety():
    # Changing any rule should break at least one test
    # E.g., if hyphens not allowed, test below would fail
    codeflash_output = is_valid_project_name("project-name")
    # If first char check removed, this would fail
    codeflash_output = is_valid_project_name("1project")
    # If invalid chars allowed, this would fail
    codeflash_output = is_valid_project_name("project_name")

# -------------------------
# 5. Readability and Maintainability
# -------------------------

@pytest.mark.parametrize("name", [
    "simpleproject",
    "simple-project",
    "simple1project",
    "Aproject",
    "a-b-c-d-e",
    "Ωmega",
    "ßbeta",
])
def test_parametrized_valid_names(name):
    # Parametrized test for valid names
    codeflash_output = is_valid_project_name(name)

@pytest.mark.parametrize("name", [
    "",
    "1simpleproject",
    "-simpleproject",
    "_simpleproject",
    "simple_project",
    "simple project",
    "simple.project",
    "simple@project",
    "project!",
])
def test_parametrized_invalid_names(name):
    # Parametrized test for invalid names
    codeflash_output = is_valid_project_name(name)
# codeflash_output is used to check that the output of the original code is the same as that of the optimized code.
#------------------------------------------------
from cli.utils import is_valid_project_name

def test_is_valid_project_name():
    is_valid_project_name('Ϸ-\x00')

def test_is_valid_project_name_2():
    is_valid_project_name('')

def test_is_valid_project_name_3():
    is_valid_project_name('»')

def test_is_valid_project_name_4():
    is_valid_project_name('𑗘')

🔎 Concolic Coverage Tests and Runtime

To edit these changes git checkout codeflash/optimize-is_valid_project_name-mh17y6j3 and push.