Skip to content

⚡️ Speed up method InMemoryNodeState.verify_token by 12% #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method InMemoryNodeState.verify_token by 12% #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions framework/py/flwr/supernode/nodestate/in_memory_nodestate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def __init__(self) -> None:
# Store node_id
self.node_id: Optional[int] = None
# Store Object ID to MessageEntry mapping
self.msg_store: dict[str, MessageEntry] = {}
self.msg_store: dict[str, "MessageEntry"] = {}
self.lock_msg_store = Lock()
# Store run ID to Run mapping
self.run_store: dict[int, Run] = {}
Expand Down Expand Up @@ -183,8 +183,13 @@ def create_token(self, run_id: int) -> Optional[str]:

def verify_token(self, run_id: int, token: str) -> bool:
"""Verify a token for the given run ID."""
with self.lock_token_store:
return self.token_store.get(run_id) == token
# Acquire lock only if needed for thread safety, do not hold longer than necessary
self.lock_token_store.acquire()
try:
value = self.token_store.get(run_id)
finally:
self.lock_token_store.release()
return value == token

def delete_token(self, run_id: int) -> None:
"""Delete the token for the given run ID."""
Expand Down