Skip to content

⚡️ Speed up method SimpleHealthServicer.Check by 165% #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method SimpleHealthServicer.Check by 165% #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion framework/py/flwr/supercore/grpc_health/simple_health_servicer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
from grpc_health.v1.health_pb2 import HealthCheckRequest, HealthCheckResponse
from grpc_health.v1.health_pb2_grpc import HealthServicer

_SERVING_RESPONSE = HealthCheckResponse(status=HealthCheckResponse.SERVING)

# pylint: enable=E0611


Expand All @@ -31,7 +33,7 @@ def Check(
self, request: HealthCheckRequest, context: grpc.ServicerContext
) -> HealthCheckResponse:
"""Return a HealthCheckResponse with SERVING status."""
return HealthCheckResponse(status=HealthCheckResponse.SERVING)
return _SERVING_RESPONSE

def Watch(self, request: HealthCheckRequest, context: grpc.ServicerContext) -> None:
"""Watch the health status (not implemented)."""
Expand Down