Skip to content

⚡️ Speed up function check_disk_space by 16% #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function check_disk_space by 16% #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ultralytics/utils/downloads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,16 +206,24 @@ def check_disk_space(url="https://ultralytics.com/assets/coco8.zip", path=Path.c

# Check file size
gib = 1 << 30 # bytes per GiB
data = int(r.headers.get("Content-Length", 0)) / gib # file size (GB)
total, used, free = (x / gib for x in shutil.disk_usage(path)) # bytes

if data * sf < free:
# Avoid constructing a generator and tuple just to unpack three values
du = shutil.disk_usage(path)
total, used, free = du[0] / gib, du[1] / gib, du[2] / gib

# Use headers.get directly as int(), avoiding repeated attribute lookup
data_header = r.headers.get("Content-Length")
# Only call int() if Content-Length is not None
data = int(data_header) / gib if data_header is not None else 0.0

required_space = data * sf
if required_space < free:
return True # sufficient space

# Insufficient space
text = (
f"WARNING ⚠️ Insufficient free disk space {free:.1f} GB < {data * sf:.3f} GB required, "
f"Please free {data * sf - free:.1f} GB additional disk space and try again."
f"WARNING ⚠️ Insufficient free disk space {free:.1f} GB < {required_space:.3f} GB required, "
f"Please free {required_space - free:.1f} GB additional disk space and try again."
)
if hard:
raise MemoryError(text)
Expand Down