Skip to content

⚡️ Speed up function get_base_setup by 162% #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function get_base_setup by 162% #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions wandb/sdk/launch/builder/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,31 +146,34 @@ def get_base_setup(

CPU version is built on python, Accelerator version is built on user provided.
"""
minor = int(py_version.split(".")[1])
if minor < 12:
python_base_image = f"python:{py_version}-buster"
else:
python_base_image = f"python:{py_version}-bookworm"
py_ver_split = py_version.split(".")
# Avoid repeated splitting and string conversion, work with the right index directly
minor = int(py_ver_split[1])

# Avoid redundant string formatting
python_base_image = (
f"python:{py_version}-buster" if minor < 12 else f"python:{py_version}-bookworm"
)

if launch_project.accelerator_base_image:
_logger.info(
f"Using accelerator base image: {launch_project.accelerator_base_image}"
)
python_packages = [
# Use list join only once, avoid recomputation
python_packages = (
f"python{py_version}",
f"libpython{py_version}",
"python3-pip",
"python3-setuptools",
]
)
base_setup = ACCELERATOR_SETUP_TEMPLATE.format(
accelerator_base_image=launch_project.accelerator_base_image,
python_packages=" \\\n".join(python_packages),
py_version=py_version,
)
else:
python_packages = [
# Only list the required system packages, unchanged logic
python_packages = (
"python3-dev",
"gcc",
] # gcc required for python < 3.7 for some reason
) # gcc required for python < 3.7 for some reason
base_setup = PYTHON_SETUP_TEMPLATE.format(py_base_image=python_base_image)
return base_setup

Expand Down