Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gems and fix style offenses #822

Merged
merged 1 commit into from
Jan 30, 2016
Merged

Update gems and fix style offenses #822

merged 1 commit into from
Jan 30, 2016

Conversation

monfresh
Copy link
Member

Note that I had to lock sprockets to < 3.0 due to a bug in requirejs-rails: jwhitley/requirejs-rails#257

@@ -1,7 +1,7 @@
%header#content-header
%h1#logo
%a{ href: '/', target: '_self' }
%img{ src: "#{asset_path(SETTINGS[:site_logo])}", alt: "#{SETTINGS[:site_title]} Logo" }
%img{ src: asset_path(SETTINGS[:site_logo]), alt: "#{SETTINGS[:site_title]} Logo" }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [89/80]

@@ -3,16 +3,16 @@
- @search.locations.each do |location|

%li
%a{ href: (location.organization.name == location.name) ? "#{location_path([location.slug], request.query_parameters)}" : "#{location_path([location.organization.slug, location.slug], request.query_parameters)}", title: "#{location.name}", name: "#{location.id}" }
%a{ href: location_link_for(location), title: location.name, name: location.id }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [88/80]

@monfresh monfresh force-pushed the update-gems branch 2 times, most recently from ea2f3f3 to 4e8bebc Compare January 30, 2016 05:07
Note that I had to lock sprockets to < 3.0 due to a bug in requirejs-rails: jwhitley/requirejs-rails#257
monfresh added a commit that referenced this pull request Jan 30, 2016
Update gems and fix style offenses
@monfresh monfresh merged commit 95c996a into master Jan 30, 2016
@monfresh monfresh deleted the update-gems branch January 30, 2016 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants