GYR1-609 Combine race ethnicity questions and add mena as demographic option

[spompea-cfa]

Link to JIRA issue

• https://codeforamerica.atlassian.net/browse/GYR1-609

Is PM acceptance required?

• Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

• Removed ethnicity screens (primary and spouse) from flow; note that the race screens are now effectively the new combined race/ethnicity screens.
• Since those were the last screens in the flow, copied over the logic from the ethnicity controllers into the race controllers (also changed a view).
• Added demographic_primary_mena and demographic_spouse_mena booleans to intakes table.
• Added MENA choice to race screens.
• Added HIspanic or Latino choice to race screens (previously was asked on separate ethnicity screen). Note that this added after a round of acceptance testing.
• Tweaked spec tests to accommodate.
• Note that "Oriente Medio o norteafricano" is directly from pg 4 of the 14-C Spanish ver.

How to test?

• Should probably confirm that:

  • race screens look OK
  • IMPORTANT: that the flow "ends" correctly -- i.e., after the race screens, the proper "you're done" post-flow works correctly
  • confirm correct values for race screen choices in the Hub
  • check both English and Spanish versions.

• Risk Assessment

  • Since the ethnicity questions where the last questions in the flow, and they were removed, making the race questions the end of the flow, we should make sure all end-of-flow / post-flow behavior is still correct.

Screenshots (for visual changes)

• Before: see /flows
• After:

[these are before acceptance testing, missing Hispanic or Latino option:]

[after acc testing; added Hispanic or Latino option:]

[github-actions]

Heroku app: https://gyr-review-app-5210-19ea931183c1.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5210 (optionally add --tail)

[powersurge360]

I wasn't able to test in the heroku instance, but the code seems fine. I added a minor nitpick you can choose to implement or not.

[powersurge360]

NIT: next_path == root_path might be a simpler boolean test.

[spompea-cfa]

👍

[spompea-cfa]

closing and reopening to create new heroku instance

[spompea-cfa]

and again

[github-actions]

Heroku app: https://gyr-review-app-5210-10cf933e87b9.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5210 (optionally add --tail)

[github-actions]

Heroku app: https://gyr-review-app-5210-3ad170c9865a.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5210 (optionally add --tail)