Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GYR1-609 Combine race ethnicity questions and add mena as demographic option #5210

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

GYR1-609 Combine race ethnicity questions and add mena as demographic option #5210

wants to merge 14 commits into from

Conversation

spompea-cfa
Copy link
Contributor

@spompea-cfa spompea-cfa commented Dec 16, 2024 •
edited
Loading

Link to JIRA issue

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Removed ethnicity screens (primary and spouse) from flow; note that the race screens are now effectively the new combined race/ethnicity screens.
  • Since those were the last screens in the flow, copied over the logic from the ethnicity controllers into the race controllers (also changed a view).
  • Added demographic_primary_mena and demographic_spouse_mena booleans to intakes table.
  • Added MENA choice to race screens.
  • Added HIspanic or Latino choice to race screens (previously was asked on separate ethnicity screen). Note that this added after a round of acceptance testing.
  • Tweaked spec tests to accommodate.
  • Note that "Oriente Medio o norteafricano" is directly from pg 4 of the 14-C Spanish ver.

How to test?

  • Should probably confirm that:

    • race screens look OK
    • IMPORTANT: that the flow "ends" correctly -- i.e., after the race screens, the proper "you're done" post-flow works correctly
    • confirm correct values for race screen choices in the Hub
    • check both English and Spanish versions.

  • Risk Assessment

    • Since the ethnicity questions where the last questions in the flow, and they were removed, making the race questions the end of the flow, we should make sure all end-of-flow / post-flow behavior is still correct.

Screenshots (for visual changes)

  • Before: see /flows
  • After:

[these are before acceptance testing, missing Hispanic or Latino option:]

primary english - Screenshot 2025-01-09 at 4 18 15 PM spouse english - Screenshot 2025-01-09 at 4 18 22 PM primary spanish - Screenshot 2025-01-09 at 4 18 46 PM spouse spanish - Screenshot 2025-01-09 at 4 18 52 PM

[after acc testing; added Hispanic or Latino option:]

image

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-5210-19ea931183c1.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5210 (optionally add --tail)

@spompea-cfa spompea-cfa force-pushed the gyr1-609-combine-race-ethnicity-questions-and-add-mena-as-demographic-option branch 2 times, most recently from af165c6 to 293176a Compare December 17, 2024 17:51
@spompea-cfa spompea-cfa changed the title [WIP] GYR1-609 combine race ethnicity questions and add mena as demographic option [WIP] GYR1-609 Combine race ethnicity questions and add mena as demographic option Dec 17, 2024
@spompea-cfa spompea-cfa changed the title [WIP] GYR1-609 Combine race ethnicity questions and add mena as demographic option [hold] GYR1-609 Combine race ethnicity questions and add mena as demographic option Dec 17, 2024
@spompea-cfa spompea-cfa force-pushed the gyr1-609-combine-race-ethnicity-questions-and-add-mena-as-demographic-option branch from 59d6e0c to 14e2ac5 Compare January 9, 2025 20:58
@spompea-cfa spompea-cfa changed the title [hold] GYR1-609 Combine race ethnicity questions and add mena as demographic option GYR1-609 Combine race ethnicity questions and add mena as demographic option Jan 9, 2025
powersurge360
powersurge360 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@powersurge360 powersurge360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to test in the heroku instance, but the code seems fine. I added a minor nitpick you can choose to implement or not.

app/views/questions/demographic_primary_race/edit.html.erb
<%= f.cfa_checkbox(:demographic_primary_white, t("general.race.white"), options: { checked_value: true, unchecked_value: false }) %>
</div>

<%= f.continue %>
<%= f.continue Questions::DemographicSpouseRaceController.show?(current_intake) ? t("general.continue") : t("general.submit") %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: next_path == root_path might be a simpler boolean test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spompea-cfa
Copy link
Contributor Author

closing and reopening to create new heroku instance

@spompea-cfa spompea-cfa reopened this Jan 16, 2025
@spompea-cfa
Copy link
Contributor Author

and again

@spompea-cfa spompea-cfa reopened this Jan 16, 2025
@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-5210-10cf933e87b9.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5210 (optionally add --tail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersurge360 powersurge360 powersurge360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spompea-cfa @powersurge360