Nj 125 income editing

[mluedke2]

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/125

Is PM acceptance required? (delete one)

• Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

• Adapted to the new XML schema for UI/WF/SWF to UIWFSWF and UIHCWD
• An overwrite method is now in the W2 model to capture intended behavior that combines UIHCWD into UIWFSWF if UIWFSWF is empty... and downstream calculators and XML for NJ1040 and NJ2450 also needed adapting for this.
• The W2 model also has validation checks for the limits for those specific types of income. The validation has to be conditional to allow for importing any info, but then turned on by the Income Review and W2 Editing controllers to not allow users to proceed without fixing.
• I decided to reuse the existing income and W2 editing controllers and forms, and put in checks for the existence of info about a given state not taxing a type of income.
• There weren't E2E tests yet specifically for just income review so I added NJ-specific tests there for this ticket's AC

How to test?

• Use Lucky to see W2 Box 14 editing, and O'Neal Walker for seeing messaging for other income forms.

Screenshots (for visual changes)

after trying to save values above the limits

[mluedke2]

@jachan @mmazanec22 this is ready for review again!

[mluedke2]

[boulder] - i need to change how i am validating the limit on W2 Box 14 because as a validation on the model I am blocking even the import of invalid values, which causes a 500 on the Lucky profile since it has a too-high value... Will likely move the validation to just be on the w2 editing form step

EDIT: Addressed now!

[mluedke2]

[boulder] - there's also a boulder on the XML export which is still exporting both UI values for box14 instead of consolidating them.

EDIT: Addressed now!

[mluedke2]

the two boulders have been addressed!